-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marbles cannot represent synchronous-upon-subscription notifications #5523
Comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
This is more of a quirk - or a gotcha - than a bug, but it does mean that some tests in our test suite might be suspect and might not be testing quite what they are described as testing.
In this PR, it wasn't possible to reproduce a failing test for the bug because a marble source like this:
emits multiple, synchronous notifications at frame zero, but - although the subscription occurs at frame zero - the notifications are not synchronous-upon-subscription.
At some stage, someone - me, I guess - is going to have to look through the tests to see whether or not tests that use sources like this are testing what they are intended to test - e.g. is this test testing what it's supposed to be testing?
Note that there are tests in the test suite that - like the test in the referenced PR - deliberately use non-marble sources to test this type of synchronous behaviour, so we just need to make sure that happens wherever that behaviour is tested.
The text was updated successfully, but these errors were encountered: