[pull] master from ReactiveX:master #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Continuing the discussion from #5538 which was closed, I feel like there is a fragmentation problem where important context for making good use of RxJs is missing from the docs. This attempts to bridge the gap, and implements the suggestion I was trying to discuss before 5538 was abruptly closed, it takes a step in the right direction by making these 3rd party packages actually visible, so readers of the docs are actually aware there is more to the ecosystem than just what is shown on the official docs.
* test(pluck): add failing test case for using null value. * fix(pluck): check for null/undefined object before attempting to access prop * Remove null coalescing when checking values to prevent null values being converted to undefined
* fix(shareReplay): subscribe to subject before source subscription happens * test(shareReplay): improve test on sync source subscription Co-authored-by: Víctor Oliva <olivarra1@gmail.com>
operator map and the first example are wrong.
revisit once ReactiveX#5523 is fixedrxjs/spec/operators/shareReplay-spec.ts Lines 277 to 282 in ea8ef13 This comment was generated by todo based on a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]. Want to support this open source service? Please star it : )