remove separate ajaxHelper module #2225
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is simple refactoring for test cases around
ajaxObservable
, by removing separate moduleajax-helper
and let each test case embeds it where it needed.Primary reason for this is removing
require
dependency inmocha
tests - I'm currently trying to simplify test / build script pipeline, which needs to remove external helpers as much to make it possible. Also this will clears #2045 as well, now internal mock for test is no longer exported at all.This PR does not includes any breaking changes.
Related issue (if exists):
#2045