build(global): enable aggressive closure optimization #2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice looking forward to this! |
|
@kwonoj do you think we could validate regressions by somehow building and running the specs against the this optimized build? This seems like something we should prioritize. |
|
As noted in PR, I already filed #2229 to change browser testing's target to use UMD build instead of CJS. I gave a quick shot and found it wasn't trivial though. |
|
I'm going to close this for now and reopen once we have pipeline for testing against browser. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables 'ADVANCED' optimization in closure compiler to generate more compressed minified global build.
Size comparsion:
gain around ~30kb of more compression.
I'm marking it as BLOCKED - cause there isn't reliable way to validate regressions of this optimization. I have filed related issue #2229, which'll allow to test global builds correctly on browsers.
Related issue (if exists):
#2229
#2227
#2225