fix(find): force unsubscribe when it completes or errors #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Force unsubscribe when resulting Observable completes or errors, even when following operator does not unsubscribe reliably, so that source Observable is not being subscribed unnecessarily.
benlesh
reviewed
Apr 12, 2017
| @@ -85,6 +85,7 @@ export class FindValueSubscriber<T> extends Subscriber<T> { | |||
|
|
|||
| destination.next(value); | |||
| destination.complete(); | |||
There was a problem hiding this comment.
This seems odd... calling complete on the destination, should end up calling unsubscribe on the destination, and subsequently up the chain to here. Although maybe I've got my head in a knot thinking about it. cc @trxcllnt
|
Thank you @Podlas29!! |
GulajavaMinistudio
added a commit
to GulajavaMinistudio/rxjs
that referenced
this pull request
May 17, 2017
fix(find): force unsubscribe when it completes or errors (ReactiveX#2550)
benlesh
added a commit
that referenced
this pull request
Jun 14, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Force unsubscribe when resulting Observable completes or errors, even when following operator does not unsubscribe reliably, so that source Observable is not being subscribed unnecessarily.
Related issue (if exists):
General description of this type of issue - #2459
The same fix for other operators - #2501 #2463 #2470