Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(find): force unsubscribe when it completes or errors (#25… #2607

Merged
merged 1 commit into from
Jun 14, 2017
Merged

Revert "fix(find): force unsubscribe when it completes or errors (#25… #2607

merged 1 commit into from
Jun 14, 2017

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented May 17, 2017

This just reverts #2550 ... I accidentally merged that, when it's a breaking change.

@Podlas29, can you possibly reopen or resubmit that PR?

@benlesh benlesh requested a review from kwonoj May 17, 2017 21:17
@rxjs-bot
Copy link

Warnings
⚠️ commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@coveralls
Copy link

coveralls commented May 17, 2017

Coverage Status

Coverage decreased (-0.0007%) to 97.734% when pulling 0358fdf on benlesh:revertFindChange into cf88a20 on ReactiveX:master.

@benlesh benlesh merged commit ca50240 into ReactiveX:master Jun 14, 2017
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants