forkJoin as a function, refactor and documentation fixes #3287
Conversation
- deletes ForkJoinObservable - implements forkJoin as just a function - Still uses the same ForkJoinSubscriber as an optimization - Improves some of the internal typings for (slightly) better type safety
Generated by 🚫 dangerJS |
---5.9KB-green.svg?style=flat-square){kind=icon}
---0.7KB-green.svg?style=flat-square){kind=icon}
|
|
||
| constructor(private parent: OuterSubscriber<T, R>, private outerValue: T, private outerIndex: number) { | ||
| constructor(private parent: OuterSubscriber<T, R>, public outerValue: T, public outerIndex: number) { |
There was a problem hiding this comment.
Double checking that going from private to public was desired. Was this changed for tests that aren't in this PR that stopped passing because they accessed these, but passed previously?
There was a problem hiding this comment.
Hmm... I remember making this change as I worked on this incrementally, because there were some ineffeciencies going on around passing these two things around. Given that OuterSubscriber is really an internal-only type, there's probably not an issue here. But if it's not being used in this PR, I can revert that part.
There was a problem hiding this comment.
Looks like the whole class is now marked @internal now, so this class will no longer be in the d.ts that gets published.
|
|
||
| constructor(private parent: OuterSubscriber<T, R>, private outerValue: T, private outerIndex: number) { | ||
| constructor(private parent: OuterSubscriber<T, R>, public outerValue: T, public outerIndex: number) { |
There was a problem hiding this comment.
Looks like the whole class is now marked @internal now, so this class will no longer be in the d.ts that gets published.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
ForkJoinObservableforkJoinas a function, with sameForkJoinSubscriberfor optimizations