Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

forkJoin as a function, refactor and documentation fixes #3287

Merged
merged 6 commits into from
Feb 6, 2018
Merged

forkJoin as a function, refactor and documentation fixes #3287

merged 6 commits into from
Feb 6, 2018

Commits on Feb 2, 2018

  1. refactor(forkJoin): eliminate ForkJoinObservable 

    - deletes ForkJoinObservable
- implements forkJoin as just a function
- Still uses the same ForkJoinSubscriber as an optimization
- Improves some of the internal typings for (slightly) better type safety
    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2280e83 View commit details
    Browse the repository at this point in the history

  2. refactor(forkJoin): remove unnecessary property

    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    78c057f View commit details
    Browse the repository at this point in the history

  3. refactor(forkJoin): remove unnecessary property assignment

    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    2c6d3d9 View commit details
    Browse the repository at this point in the history

  4. refactor(forkJoin): improve type safety of resultSelector call

    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    6d81b58 View commit details
    Browse the repository at this point in the history

  5. style(forkJoin): destructure destination with others

    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    af8fac6 View commit details
    Browse the repository at this point in the history

  6. docs(forkJoin): update examples to v6 imports

    @benlesh
    benlesh committed Feb 2, 2018
    Configuration menu
    Copy the full SHA
    b2ad7ad View commit details
    Browse the repository at this point in the history