Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(shareReplay): add the shareReplay() operator #447

Merged
merged 1 commit into from
Oct 6, 2015
Merged

feat(shareReplay): add the shareReplay() operator #447

merged 1 commit into from
Oct 6, 2015

Conversation

staltz
Copy link
Member

@staltz staltz commented Oct 2, 2015

Add shareReplay() as a core operator. Vaguely relates to issue #439 and issue #298.

@staltz
Copy link
Member Author

staltz commented Oct 2, 2015

Bad news:

node perf/micro share-replay
Testing against RxJS v 3.1.2
old shareReplay with immediate scheduler x 50,064 ops/sec ±5.09% (77 runs sampled)
new shareReplay with immediate scheduler x 18,841 ops/sec ±1.61% (81 runs sampled)
        -62.37% slower than Rx v 3.1.2

I have an idea what the culprit is, but I'll submit the fix separately.

@staltz staltz mentioned this pull request Oct 2, 2015
Closed
@benlesh
Copy link
Member

benlesh commented Oct 6, 2015

Can you rebase this one please? I appreciate the help.

feat(shareReplay): add the shareReplay() operator
65c84ea 
Add shareReplay() as a core operator. Vaguely relates to issue ReactiveX#439 and
issue ReactiveX#298.
@staltz
Copy link
Member Author

staltz commented Oct 6, 2015

Ready.

@benlesh benlesh merged commit 65c84ea into ReactiveX:master Oct 6, 2015
@staltz staltz deleted the shareReplay branch October 6, 2015 16:51
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@staltz @benlesh