perf(ReplaySubject): remove unnecessary computation #448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary call to
_getEvents()
in ReplaySubject's_next()
. No apparent reason for doing this. All tests still pass after this commit.Please merge PR #447 before merging this PR. When running the micro perf test for shareReplay after this commit is applied, we get this result:
I don't know why that line was there in ReplaySubject.ts. Seems to contribute nothing to the behavior of ReplaySubject.