Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ReplaySubject): remove unnecessary computation #448

Closed
wants to merge 1 commit into from

Conversation

staltz
Copy link
Member

@staltz staltz commented Oct 2, 2015

Remove unnecessary call to _getEvents() in ReplaySubject's _next(). No apparent reason for doing this. All tests still pass after this commit.

Please merge PR #447 before merging this PR. When running the micro perf test for shareReplay after this commit is applied, we get this result:

node perf/micro share-replay
Testing against RxJS v 3.1.2
old shareReplay with immediate scheduler x 44,835 ops/sec ±16.27% (87 runs sampled)
new shareReplay with immediate scheduler x 92,828 ops/sec ±1.57% (92 runs sampled)
        107.05% faster than Rx v 3.1.2

I don't know why that line was there in ReplaySubject.ts. Seems to contribute nothing to the behavior of ReplaySubject.

Remove unnecessary call to _getEvents() in ReplaySubject's _next().
No apparent reason for doing this. All tests still pass after this
commit.
@benlesh
Copy link
Member

benlesh commented Oct 6, 2015

Blocked by #447

@benlesh benlesh added the blocked label Oct 6, 2015
@staltz
Copy link
Member Author

staltz commented Oct 6, 2015

Blocked but #447 is now mergeable, so soon this should be as well.

@benlesh benlesh removed the blocked label Oct 6, 2015
@benlesh
Copy link
Member

benlesh commented Oct 6, 2015

Merged with 488ac2e... thanks, @staltz

@benlesh benlesh closed this Oct 6, 2015
@staltz staltz deleted the faster-replay-subject branch October 6, 2015 16:51
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants