Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deprecations): fix some typos in Scheduler Argument #7119

Merged
merged 2 commits into from
Mar 31, 2023
Merged

docs(deprecations): fix some typos in Scheduler Argument #7119

merged 2 commits into from
Mar 31, 2023

Conversation

BrainCrumbz
Copy link
Contributor

Description:

This PR is to fix a couple of typos found in "Scheduler Argument" page within "Deprecations & breaking changes" section.

@@ -24,13 +24,13 @@ To support this transition the [scheduled creation function](/api/index/function

## How to Refactor

If you use any other operator from the list above and using the `scheduler` argument, you have to three potential refactoring options.
If you use any operator from the list above and also use the `scheduler` argument, you have three potential refactoring options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you use any operator from the list above and also use the `scheduler` argument, you have three potential refactoring options.
If you use any operator from the above list and you're passing the `scheduler` argument, you have three potential refactoring options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just applied changes

Copy link
Member

@jakovljevic-mladen jakovljevic-mladen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@jakovljevic-mladen jakovljevic-mladen merged commit 5353ca4 into ReactiveX:master Mar 31, 2023
jakovljevic-mladen pushed a commit that referenced this pull request Mar 31, 2023
* docs(deprecations): fix some typos in Scheduler Argument

* docs(deprecations): apply PR suggestions

Ref. #7119 (review)

(cherry picked from commit 5353ca4)
@BrainCrumbz BrainCrumbz deleted the docs/scheduler-arg-typos branch March 31, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants