Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(deprecations): fix some typos in Scheduler Argument #7119

Merged
merged 2 commits into from
Mar 31, 2023
Merged

docs(deprecations): fix some typos in Scheduler Argument #7119

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452af38
docs(deprecations): fix some typos in Scheduler Argument
BrainCrumbz Nov 21, 2022
9358696
docs(deprecations): apply PR suggestions
BrainCrumbz Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs_app/content/deprecations/scheduler-argument.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ To support this transition the [scheduled creation function](/api/index/function

## How to Refactor

If you use any other operator from the list above and using the `scheduler` argument, you have to three potential refactoring options.
If you use any operator from the list above and also use the `scheduler` argument, you have three potential refactoring options.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you use any operator from the list above and also use the `scheduler` argument, you have three potential refactoring options.
If you use any operator from the above list and you're passing the `scheduler` argument, you have three potential refactoring options.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just applied changes


### Refactoring of `of` and `from`

`scheduled` is kinda copying the behavior of `from`. Therefore if you used `from` with a `scheduler` argument, you can just replace them.

For the `of` creation function you need to this Observable with `scheduled` and instead of passing the `scheduler` argument to `of` pass it to `scheduled`.
For the `of` creation function you need to replace this Observable with `scheduled` and instead of passing the `scheduler` argument to `of` pass it to `scheduled`.
Following code example demonstrate this process.

```ts
Expand Down