Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Repeated Dependency Update PRs from Renovate Bot #2342

Open
6 of 10 tasks
vikasosmium opened this issue Jan 9, 2025 · 0 comments
Open
6 of 10 tasks

Fix: Repeated Dependency Update PRs from Renovate Bot #2342

vikasosmium opened this issue Jan 9, 2025 · 0 comments
Assignees
@vikasosmium
Labels
backend dependencies Pull requests that update a dependency file RFC

Comments

@vikasosmium
Copy link
Contributor

vikasosmium commented Jan 9, 2025 •
edited
Loading

Issue Description

Renovate bot keeps tagging outdated package dependencies and raising multiple PRs, which need to be consolidated and resolved.

Expected Behavior

All package dependencies should be updated in a single PR to avoid multiple unnecessary updates and PR clutter.

Current Behavior

Renovate bot continuously tags outdated dependencies and raises individual PRs for each, causing clutter and redundant review efforts.

Screenshots

Reproducibility

  • This issue is reproducible
  • This issue is not reproducible

Steps to Reproduce

  1. Observe the Renovate bot raising multiple PRs for each outdated dependency.
  2. Review the PR list for excessive dependency update requests.

Severity/Priority

  • Critical
  • High
  • Medium
  • Low

Additional Information

Checklist

  • I have read and followed the project's code of conduct.
  • I have searched for similar issues before creating this one.
  • I have provided all the necessary information to understand and reproduce the issue.
  • I am willing to contribute to the resolution of this issue.
@vikasosmium vikasosmium added dependencies Pull requests that update a dependency file backend RFC labels Jan 9, 2025
@vikasosmium vikasosmium self-assigned this Jan 9, 2025
@vikasosmium vikasosmium mentioned this issue Jan 9, 2025
Merged
10 tasks
@vikasosmium vikasosmium changed the title Update Package Dependencies Fix: Repeated Dependency Update PRs from Renovate Bot Jan 9, 2025
yesyash pushed a commit that referenced this issue Jan 9, 2025
@vikasosmium
chore(#2342) - upgraded dependency packages
5bc49c6
yesyash added a commit that referenced this issue Jan 10, 2025
@yesyash
Revert "chore(#2342) - upgraded dependency packages"
028dd40 
This reverts commit 5bc49c6.
yesyash added a commit that referenced this issue Jan 10, 2025
@yesyash
Revert "chore(#2342) - upgraded dependency packages" (#2343)
1ffa717 
This reverts commit 5bc49c6.
iamitprakash pushed a commit that referenced this issue Jan 11, 2025
@Achintya-Chatterjee @pankajjs
@AnujChhikara @prakashchoudhary07 @vikasosmium @yesyash
Dev to Main Sync (#2336)
4bf146e 
* feat: Add api to create onboarding extension request from discord server (#2307)

* fix:added onboarding type in request

* feat: added types for onboarding extension request

* feat: added validator and skip-authenticate middleware

* fix: added missing field in user type

* feat: added controller for handling the create onboarding extension request feature

* fix: remove requestedBy field because validation for super-users is done before hitting this api

* refactor: moved constant messages from controller

* fix: remove super-users validation check as it is done before making this api call

* fix: create newEndsOn from current date when deadline has missed

* fix: wrap schema validation logic in try-catch block

* chore: refactor varibale name for better readability

* chore: refactor new deadline calculation logic in a separate utils file for reuse

* chore: use utils function to calculate days to milliseconds

* feat: added utils function to validate date

* fix: return error response for invalid date

* fix: return forbidden response for non-onboarding user

* chore: added semicolon for consistent code practise

* chore: added jsDoc for functions and refactor import statment

* fix: import addLog from service file and fix lint issue

* Add tests for create onboarding extension request api (#2306)

* feat: added tests for middlewares

* feat:added tests for controller

* refactor: create middleware in beforeEach hook

* refactor: remove requestBy field and super-users validation tests

* fix: expectation message as test was failing

* fix: change order of middleware creation as test was failing

* fix: assert statement and mock value

* feat: added tests for handling edges cases and fixed existing test

* chore: correct test name

* chore: fix lint issue

* feat: Integrate userData into Progresses API to reduce redundant calls (#2311)

* initial

* fix typos

* using batches to fetch userIds

* refactor the function

* added test for dev false case

* added unit tests

* fix response body containing email

---------

Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>

* fix: Changed status code to 409 for sending Conflict response (#2339)

* chore(#2342) - upgraded dependency packages

* Revert "chore(#2342) - upgraded dependency packages" (#2343)

This reverts commit 5bc49c6.

---------

Co-authored-by: Pankaj <pankajshadev@gmail.com>
Co-authored-by: Anuj Chhikara <107175639+AnujChhikara@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>
yesyash added a commit that referenced this issue Jan 18, 2025
@Achintya-Chatterjee @iamitprakash
@pankajjs @AnujChhikara @prakashchoudhary07 @vikasosmium @yesyash
fix : merge conflicts (#2356)
52822ad 
* Dev to Main Sync  (#2336)

* feat: Add api to create onboarding extension request from discord server (#2307)

* fix:added onboarding type in request

* feat: added types for onboarding extension request

* feat: added validator and skip-authenticate middleware

* fix: added missing field in user type

* feat: added controller for handling the create onboarding extension request feature

* fix: remove requestedBy field because validation for super-users is done before hitting this api

* refactor: moved constant messages from controller

* fix: remove super-users validation check as it is done before making this api call

* fix: create newEndsOn from current date when deadline has missed

* fix: wrap schema validation logic in try-catch block

* chore: refactor varibale name for better readability

* chore: refactor new deadline calculation logic in a separate utils file for reuse

* chore: use utils function to calculate days to milliseconds

* feat: added utils function to validate date

* fix: return error response for invalid date

* fix: return forbidden response for non-onboarding user

* chore: added semicolon for consistent code practise

* chore: added jsDoc for functions and refactor import statment

* fix: import addLog from service file and fix lint issue

* Add tests for create onboarding extension request api (#2306)

* feat: added tests for middlewares

* feat:added tests for controller

* refactor: create middleware in beforeEach hook

* refactor: remove requestBy field and super-users validation tests

* fix: expectation message as test was failing

* fix: change order of middleware creation as test was failing

* fix: assert statement and mock value

* feat: added tests for handling edges cases and fixed existing test

* chore: correct test name

* chore: fix lint issue

* feat: Integrate userData into Progresses API to reduce redundant calls (#2311)

* initial

* fix typos

* using batches to fetch userIds

* refactor the function

* added test for dev false case

* added unit tests

* fix response body containing email

---------

Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>

* fix: Changed status code to 409 for sending Conflict response (#2339)

* chore(#2342) - upgraded dependency packages

* Revert "chore(#2342) - upgraded dependency packages" (#2343)

This reverts commit 5bc49c6.

---------

Co-authored-by: Pankaj <pankajshadev@gmail.com>
Co-authored-by: Anuj Chhikara <107175639+AnujChhikara@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>

* fix: merge conflicts

---------

Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
Co-authored-by: Pankaj <pankajshadev@gmail.com>
Co-authored-by: Anuj Chhikara <107175639+AnujChhikara@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>
yesyash pushed a commit that referenced this issue Jan 18, 2025
@vikasosmium @yesyash
chore(#2342) - upgraded dependency packages
e225baa
yesyash added a commit that referenced this issue Jan 18, 2025
@yesyash
Revert "chore(#2342) - upgraded dependency packages" (#2343)
1e8194a 
This reverts commit 5bc49c6.
yesyash added a commit that referenced this issue Jan 18, 2025
@Achintya-Chatterjee @iamitprakash
@pankajjs @AnujChhikara @prakashchoudhary07 @vikasosmium @yesyash
fix : merge conflicts (#2356)
43e8466 
* Dev to Main Sync  (#2336)

* feat: Add api to create onboarding extension request from discord server (#2307)

* fix:added onboarding type in request

* feat: added types for onboarding extension request

* feat: added validator and skip-authenticate middleware

* fix: added missing field in user type

* feat: added controller for handling the create onboarding extension request feature

* fix: remove requestedBy field because validation for super-users is done before hitting this api

* refactor: moved constant messages from controller

* fix: remove super-users validation check as it is done before making this api call

* fix: create newEndsOn from current date when deadline has missed

* fix: wrap schema validation logic in try-catch block

* chore: refactor varibale name for better readability

* chore: refactor new deadline calculation logic in a separate utils file for reuse

* chore: use utils function to calculate days to milliseconds

* feat: added utils function to validate date

* fix: return error response for invalid date

* fix: return forbidden response for non-onboarding user

* chore: added semicolon for consistent code practise

* chore: added jsDoc for functions and refactor import statment

* fix: import addLog from service file and fix lint issue

* Add tests for create onboarding extension request api (#2306)

* feat: added tests for middlewares

* feat:added tests for controller

* refactor: create middleware in beforeEach hook

* refactor: remove requestBy field and super-users validation tests

* fix: expectation message as test was failing

* fix: change order of middleware creation as test was failing

* fix: assert statement and mock value

* feat: added tests for handling edges cases and fixed existing test

* chore: correct test name

* chore: fix lint issue

* feat: Integrate userData into Progresses API to reduce redundant calls (#2311)

* initial

* fix typos

* using batches to fetch userIds

* refactor the function

* added test for dev false case

* added unit tests

* fix response body containing email

---------

Co-authored-by: Achintya Chatterjee <55826451+Achintya-Chatterjee@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>

* fix: Changed status code to 409 for sending Conflict response (#2339)

* chore(#2342) - upgraded dependency packages

* Revert "chore(#2342) - upgraded dependency packages" (#2343)

This reverts commit 5bc49c6.

---------

Co-authored-by: Pankaj <pankajshadev@gmail.com>
Co-authored-by: Anuj Chhikara <107175639+AnujChhikara@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>

* fix: merge conflicts

---------

Co-authored-by: Amit Prakash <34869115+iamitprakash@users.noreply.github.com>
Co-authored-by: Pankaj <pankajshadev@gmail.com>
Co-authored-by: Anuj Chhikara <107175639+AnujChhikara@users.noreply.github.com>
Co-authored-by: Prakash Choudhary <34452139+prakashchoudhary07@users.noreply.github.com>
Co-authored-by: Vikas Singh <59792866+vikasosmium@users.noreply.github.com>
Co-authored-by: Yash Raj <56453897+yesyash@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vikasosmium vikasosmium

Labels
backend dependencies Pull requests that update a dependency file RFC
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vikasosmium