-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update user count when discord role is removed #648
base: develop
Are you sure you want to change the base?
update user count when discord role is removed #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test to cover this case
Done @Ajeyakrishna-k |
Please add passing test snapshot for the particular test added in the PR. |
__tests__/groups/group.test.js
Outdated
await deleteRoleBtn.click(); | ||
|
||
// Now, check the user count | ||
if (userCount != null) expect(userCount).toBe(userCount - 1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to check for userCount not being null and skip the the assertion.
Tests (even those which were written earlier) are failing in my local environment (dev branch as well ), as I had mentioned to you earlier. Therefore I have not attached it. |
…ant/website-dashboard into discord_group_count
…ant/website-dashboard into discord_group_count
Date: 16/12/2023
Developer Name: @PeeyushPrashant
Issue Closes #623
What is the change?
document.getElementById method .
Documentation Updated?
Breaking Changes
Development Tested?
Tested in Staging?
Under Feature Flag
Database Changes
Before & After Change Screenshots
screen-capture.4.webm
Test Coverage
Additional Notes
These tests are failing in dev branch as well, it has not happened because of my changes.