Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update user count when discord role is removed #648

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions __tests__/groups/group.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,34 @@ describe('Discord Groups Page', () => {
expect(buttonText).toBe('Remove me from this group');
});

test('Should decrease user count by one when user is removed from group', async () => {
await page.goto('http://localhost:8000/groups/?dev=true');
await page.$$eval('.group-role', (elements) => {
elements[1].click();
});

const oldUserCount = await page.$$eval('.group-role', (elements) => {
return elements[1]
.querySelector('[id^="name-"]')
.getAttribute('data-member-count');
});

// Wait for the btn-add-role and click it
const deleteRoleBtn = await page.$('.btn-add-role');
await deleteRoleBtn.click();

await page.waitForNetworkIdle();

const newUserCount = await page.$$eval('.group-role', (elements) => {
return elements[1]
.querySelector('[id^="name-"]')
.getAttribute('data-member-count');
});

// Now, check the user count
expect(Number(newUserCount)).toBe(Number(oldUserCount - 1));
});

test('Should show role deleted', async () => {
await page.$$eval('.group-role', (elements) => {
elements[1].click();
Expand Down
9 changes: 9 additions & 0 deletions groups/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,15 @@ async function removeRoleHandler() {
memberAddRoleBody.roleid,
memberAddRoleBody.userid,
);
if (isDev) {
const groupNameElement = document.getElementById(
`name-${memberAddRoleBody.roleid}`,
);
const currentCount = groupNameElement.getAttribute('data-member-count');
if (currentCount !== null && currentCount !== undefined) {
groupNameElement.setAttribute('data-member-count', currentCount - 1);
}
}
showToaster(res.message);
UserGroupData = await getUserGroupRoles();
updateButtonState();
Expand Down
Loading