Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(chart): sw-2707 remove deprecated react #1478

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 13, 2024

What's included

  • refactor(chart): sw-2707 remove deprecated react

Notes

  • remove proptypes, replace default props

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-2707

@cdcabrera cdcabrera added the 202412 project phase label Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (3935bf0) to head (b72a359).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1478      +/-   ##
==========================================
- Coverage   91.42%   91.40%   -0.03%     
==========================================
  Files         115      115              
  Lines        4724     4723       -1     
  Branches     2184     2190       +6     
==========================================
- Hits         4319     4317       -2     
- Misses        379      380       +1     
  Partials       26       26              
Files with missing lines Coverage Δ
src/components/chart/chart.js 91.42% <100.00%> (+0.51%) ⬆️
src/components/chart/chartElements.js 86.48% <100.00%> (ø)
src/components/chart/chartIcon.js 97.67% <100.00%> (-0.06%) ⬇️
src/components/chart/chartLegend.js 100.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3935bf0...b72a359. Read the comment docs.

@cdcabrera cdcabrera marked this pull request as ready for review November 13, 2024 14:31
@cdcabrera cdcabrera merged commit 20605de into RedHatInsights:main Nov 13, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants