Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): sw-2966 consistent x-axis for all products #1481

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cdcabrera
Copy link
Member

@cdcabrera cdcabrera commented Nov 13, 2024

What's included

fix(config): sw-2966 consistent x-axis for all products

Notes

How to test

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. confirm the x-axis ticks now increment the same for all products, ROSA and Ansible displays specifically

Example

what it looks like in test/stage/local
Screenshot 2024-11-13 at 12 03 45 PM

expected results
Screenshot 2024-11-13 at 12 04 14 PM

Updates issue/story

related #1426 #1480 and #1478 and sw-2707
sw-2966

@cdcabrera cdcabrera added the 202412 project phase label Nov 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (a895e96) to head (286acb4).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1481   +/-   ##
=======================================
  Coverage   91.40%   91.40%           
=======================================
  Files         115      115           
  Lines        4723     4723           
  Branches     2190     2190           
=======================================
  Hits         4317     4317           
  Misses        380      380           
  Partials       26       26           
Files with missing lines Coverage Δ
src/config/product.ansible.js 81.25% <ø> (ø)
src/config/product.rosa.js 82.35% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a895e96...286acb4. Read the comment docs.

@cdcabrera cdcabrera merged commit 7c535bd into RedHatInsights:main Nov 13, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants