Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chart): sw-2707 shallow comparison for context #1480

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

cdcabrera
Copy link
Member

What's included

  • fix(chart): sw-2707 shallow comparison for context

Notes

  • quick patch, moves from useEffect to a shallow comparison related to updating chart context. we'll reevaluate towards using useMemo or a simple memoized helper in subsequent updates

How to test

Coverage and basic unit test check

  1. update the NPM packages with $ npm install
  2. $ npm test
  3. confirm tests come back clean

Local run check

  1. update the NPM packages with $ npm install
  2. $ npm start
  3. confirm charts display as intended
    • confirm charts update correctly when filters are selected

Proxy run check

  1. update the NPM packages with $ npm install
  2. make sure you're on network, then
  3. $ npm run start:proxy
  4. confirm charts display as intended
    • confirm charts update correctly when filters are selected

Check the build

  1. update the NPM packages with $ npm install
  2. $ npm run build
  3. confirm tests come back clean

Example

...

Updates issue/story

sw-2707

@cdcabrera cdcabrera added the 202412 project phase label Nov 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.42%. Comparing base (ec6b23c) to head (23e6beb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1480   +/-   ##
=======================================
  Coverage   91.42%   91.42%           
=======================================
  Files         115      115           
  Lines        4724     4724           
  Branches     2184     2184           
=======================================
  Hits         4319     4319           
  Misses        379      379           
  Partials       26       26           
Files with missing lines Coverage Δ
src/components/chart/chart.js 90.90% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec6b23c...23e6beb. Read the comment docs.

@cdcabrera cdcabrera merged commit 3935bf0 into RedHatInsights:main Nov 13, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202412 project phase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants