fix(chart): sw-2707 shallow comparison for context #1480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's included
Notes
useEffect
to a shallow comparison related to updating chart context. we'll reevaluate towards usinguseMemo
or a simple memoized helper in subsequent updatesHow to test
Coverage and basic unit test check
$ npm install
$ npm test
Local run check
$ npm install
$ npm start
Proxy run check
$ npm install
$ npm run start:proxy
Check the build
$ npm install
$ npm run build
Example
...
Updates issue/story
sw-2707