This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Include internal rules #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
==========================================
+ Coverage 73.15% 73.72% +0.57%
==========================================
Files 9 9
Lines 365 373 +8
==========================================
+ Hits 267 275 +8
Misses 79 79
Partials 19 19
Continue to review full report at Codecov.
|
Bee-lee
requested review from
bond95,
joselsegura,
natiiix,
quarckster,
Serhii1011010 and
tisnik
as code owners
quarckster
suggested changes
Jul 9, 2020
* Adding reason to Error keys * Modifying the rule/error key parsing process * Updating checking for missing fields * Some nitpicks from linters * Fixing error control * Increasing coverage * Incresing coverage II * Solving minor comment
Bee-lee
force-pushed
the
include-internal-rules
branch
from
0bdad24 to
883997e
Compare
quarckster
approved these changes
Jul 9, 2020
joselsegura
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds internal rules content parsing.
Was blocked by: RedHatInsights/insights-results-smart-proxy#85
Fixes #71
Type of change
Testing steps
make before_commit+ testing alongside smart-proxy