Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include hyphenated worker names #262

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

subpop
Copy link
Collaborator

@subpop subpop commented Sep 12, 2024

When publishing the dispatchers table, include both underscore names and classic hyphenated names. This cannot cause any conflict with existing/local workers since hyphens in worker names is disallowed by the D-Bus name policy.

Card ID: RHEL-58762

When publishing the dispatchers table, include both underscore names
and classic hyphenated names.
@subpop subpop force-pushed the dispatcher-name-compat branch from 42a681b to 92bea5a Compare September 13, 2024 10:25
@subpop subpop requested a review from jirihnidek September 13, 2024 10:26
Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@subpop
Copy link
Collaborator Author

subpop commented Sep 13, 2024

/packit rebuild-failed

@subpop
Copy link
Collaborator Author

subpop commented Sep 13, 2024

centos-stream-10-aarch64 is failing for unrelated reasons.

Errors during downloading metadata for repository 'crb':

  • Downloading successful, but checksum doesn't match. Calculated: 516a13a7b08f0625d8018aba2b34e8bbdd54ef7ea62e4efcfcebdcc16ee8f7a230ce2ee0c473507ef4ba8e544879ac76b46d79565c2a11ee0445cde4e2cd2fa8(sha512) Expected: 7e25143ad7f08f2802752b86c409a39323eaecb5547f4f0885d2e0f0339184b4b137239d97edbab145369a4d0444ad2f24e3d5e7cd8f84db5493c8bac8720167(sha512)
    Error: Failed to download metadata for repo 'crb': Cannot download repomd.xml: Cannot download repodata/repomd.xml: All mirrors were tried

I think we can merge this despite the failure.

@subpop subpop merged commit 66778b8 into RedHatInsights:main Sep 13, 2024
33 of 35 checks passed
@subpop subpop deleted the dispatcher-name-compat branch September 13, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants