Skip to content

Commit

Permalink
Merge pull request #108 from RelationalAI/mm-shapely
Browse files Browse the repository at this point in the history
Allow Shape to be used in Front benchmarks
  • Loading branch information
azreika authored Nov 8, 2024
2 parents ef3bffe + f9c3da2 commit f631066
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions src/linting/extended_checks.jl
Original file line number Diff line number Diff line change
Expand Up @@ -503,9 +503,11 @@ function check(t::NonFrontShapeAPIUsageRule, x::EXPR, markers::Dict{Symbol,Strin
contains(markers[:filename], "src/FrontCompiler") && return
contains(markers[:filename], "src/FFI") && return
contains(markers[:filename], "src/FrontIR") && return
# Also, allow usages in tests
# Allow usage in Front benchmarks
contains(markers[:filename], "bench/Front") && return
# Allow usages in tests
contains(markers[:filename], "test/") && return
# Also, allow usages of the name `Shape` in `packages/` although they refer to a different thing.
# Allow usages of the name `Shape` in `packages/` although they refer to a different thing.
contains(markers[:filename], "packages/RAI_Protos/src/proto/metadata.proto") && return
contains(markers[:filename], "packages/RAI_Protos/src/gen/relationalai/protocol/metadata_pb.jl") && return

Expand Down

0 comments on commit f631066

Please sign in to comment.