Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Shape to be used in Front benchmarks #108

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Allow Shape to be used in Front benchmarks #108

merged 1 commit into from
Nov 8, 2024

Conversation

mmcgr
Copy link
Contributor

@mmcgr mmcgr commented Nov 8, 2024

No description provided.

@mmcgr mmcgr requested review from gkastrinis, azreika and a team November 8, 2024 00:39
Copy link

github-actions bot commented Nov 8, 2024

Static code analyzer report

Output of the StaticLint.jl code analyzer. 🫵Want to contribute?🫵 RelationalAI Style Guide for Julia
Report creation time (UTC): (2024-11-08T00:40:51.531)

  • Line 58, column 43: Use $(x) instead of $x (explanation). raicode/src/linting/extended_checks.jl
  • Line 293, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 349, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 352, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 353, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 393, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 489, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 501, column 5: Use thaskey(dict,key) instead of the Julia's haskey. raicode/src/linting/extended_checks.jl
  • Line 536, column 26: Use tin(item,collection) instead of the Julia's in or . raicode/src/linting/extended_checks.jl
    🚨In total, 9 rule violations and 0 PR reviewer recommendation are found over 1 Julia file🚨

Copy link
Contributor

@azreika azreika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@azreika azreika merged commit f631066 into main Nov 8, 2024
7 checks passed
@azreika azreika deleted the mm-shapely branch November 8, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants