-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hazard rate calculations not recursively calculated #982
Conversation
Co-authored-by: Sourcery AI <>
Sourcery Code Quality Report❌ Merging this PR will decrease code quality in the affected files by 1.27%.
Here are some functions in these files that still need a tune-up:
Legend and ExplanationThe emojis denote the absolute quality of the code:
The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request. Please see our documentation here for details on how these metrics are calculated. We are actively working on this report - lots more documentation and extra metrics to come! Help us improve this quality report! |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 94.84% 94.86% +0.01%
==========================================
Files 158 158
Lines 5254 5274 +20
Branches 515 515
==========================================
+ Hits 4983 5003 +20
Misses 234 234
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Does this PR introduce a breaking change?
Describe the purpose of this pull request.
To make hardware calculations recursive.
Describe how this was implemented.
Split do_calculate_hardware() method into one method per attribute to calculate. Added for loop with incrementing value in each new method to account for the need to sum children quantities for the parent.
Describe any particular area(s) reviewers should focus on.
None
Provide any other pertinent information.
Close #960
Pull Request Checklist
Code Style
Static Checks
this PR.
Tests
Chores
decorating the code block. These # ISSUE: comments are automatically
converted to issues on successful merge. Alternatively, you can manually
raise an issue for each problem area you identify.