Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hazard rate calculations not recursively calculated (Sourcery refactored) #983

Merged
merged 1 commit into from
Feb 20, 2022

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Feb 20, 2022

Pull Request #982 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the fix/issue-960 branch, then run:

git fetch origin sourcery/fix/issue-960
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai
Copy link
Contributor Author

sourcery-ai bot commented Feb 20, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.91%.

Quality metrics Before After Change
Complexity 3.62 ⭐ 3.77 ⭐ 0.15 👎
Method Length 60.18 ⭐ 59.45 ⭐ -0.73 👍
Working memory 6.02 ⭐ 6.09 ⭐ 0.07 👎
Quality 75.08% 74.17% 🙂 -0.91% 👎
Other metrics Before After Change
Lines 391 388 -3
Changed files Quality Before Quality After Quality Change
src/ramstk/analyses/milhdbk217f/models/inductor.py 75.08% ⭐ 74.17% 🙂 -0.91% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/ramstk/analyses/milhdbk217f/models/inductor.py calculate_part_stress 10 🙂 195 😞 9 🙂 51.14% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@weibullguy weibullguy merged commit ec710b2 into fix/issue-960 Feb 20, 2022
@trafico-bot trafico-bot bot added the endgame: merged Pull Request has been merged successfully label Feb 20, 2022
@weibullguy weibullguy deleted the sourcery/fix/issue-960 branch February 20, 2022 06:36
weibullguy added a commit that referenced this pull request Feb 20, 2022
* fix: hazard rate calculations will now recurse

* test: update tests for recursive hazard rates

* ci: only run open PR workflow against master

* 'Refactored by Sourcery' (#983)

Co-authored-by: Sourcery AI <>

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
@weibullguy weibullguy added the status: closed Pull Request is complete and integrated or closed for anther reason. label Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
endgame: merged Pull Request has been merged successfully status: closed Pull Request is complete and integrated or closed for anther reason.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant