Refactor Size rule #1487
Merged
Refactor Size rule #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henriquemoody
force-pushed
the
rule/size
branch
2 times, most recently
from
cdcf090 to
9ecdf70
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1487 +/- ##
============================================
- Coverage 96.55% 96.54% -0.02%
- Complexity 967 973 +6
============================================
Files 200 201 +1
Lines 2354 2403 +49
============================================
+ Hits 2273 2320 +47
- Misses 81 83 +2 ☔ View full report in Codecov by Sentry. |
henriquemoody
force-pushed
the
rule/size
branch
from
9ecdf70 to
82516c6
Compare
Currently, the Size rule does multiple things, yet it's limited. Because it does many things, it's also confusing. Turning the Size rule into a transformation allows for way more flexibility and clarity. The syntax becomes more verbose, but the rule becomes more reusable.
henriquemoody
force-pushed
the
rule/size
branch
from
82516c6 to
6e3ed79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.