Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Size rule #1487

Merged
merged 1 commit into from
Dec 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/09-list-of-rules-by-category.md
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,7 @@
- [Length](rules/Length.md)
- [Max](rules/Max.md)
- [Min](rules/Min.md)
- [Size](rules/Size.md)

## Types

Expand Down
82 changes: 39 additions & 43 deletions docs/rules/Size.md
Original file line number Diff line number Diff line change
@@ -1,78 +1,71 @@
# Size

- `Size(string $minSize)`
- `Size(string $minSize, string $maxSize)`
- `Size(null, string $maxSize)`
- `Size(string $unit, Rule $rule)`

Validates whether the input is a file that is of a certain size or not.

```php
v::size('1KB')->isValid($filename); // Must have at least 1KB size
v::size('1MB', '2MB')->isValid($filename); // Must have the size between 1MB and 2MB
v::size(null, '1GB')->isValid($filename); // Must not be greater than 1GB
v::size('KB', v::greaterThan(1))->isValid($filename);
v::size('MB', v::between(1, 2))->isValid($filename);
v::size('GB', v::lessThan(1))->isValid($filename);
```

Sizes are not case-sensitive and the accepted values are:
Accepted data storage units are `B`, `KB`, `MB`, `GB`, `TB`, `PB`, `EB`, `ZB`, and `YB`.

- B
- KB
- MB
- GB
- TB
- PB
- EB
- ZB
- YB
This validator will accept:

This validator will consider `SplFileInfo` instances, like:
* `string` file paths
* `SplFileInfo` objects (see [SplFileInfo][])
* `Psr\Http\Message\UploadedFileInterface` objects (see [PSR-7][])
* `Psr\Http\Message\StreamInterface` objects (see [PSR-7][])

```php
v::size('1.5mb')->isValid(new SplFileInfo($filename)); // Will return true or false
```
## Templates

Message template for this validator includes `{{minSize}}` and `{{maxSize}}`.
### `Size::TEMPLATE_STANDARD`

## Templates
| Mode | Template |
|------------|------------------------------------|
| `default` | The size in {{unit|trans}} of |
| `inverted` | The size in {{unit|trans}} of |

### `Size::TEMPLATE_BOTH`
This template serve as message prefix:

| Mode | Template |
|------------|----------------------------------------------------------|
| `default` | {{name}} must be between {{minSize}} and {{maxSize}} |
| `inverted` | {{name}} must not be between {{minSize}} and {{maxSize}} |
```php
v::size('MB', v::equals(2))->assert('filename.txt')
// Message: The size in megabytes of "filename.txt" must be equal to 2

### `Size::TEMPLATE_LOWER`
v::size('KB', v::not(v::equals(56)))->assert('filename.txt')
// Message: The size in kilobytes of "filename.txt" must not be equal to 56
```

| Mode | Template |
|------------|-----------------------------------------------|
| `default` | {{name}} must be greater than {{minSize}} |
| `inverted` | {{name}} must not be greater than {{minSize}} |
### `Size::TEMPLATE_WRONG_TYPE`

### `Size::TEMPLATE_GREATER`
Used when the input is not a valid file path, a `SplFileInfo` object, or a PSR-7 interface.

| Mode | Template |
|------------|---------------------------------------------|
| `default` | {{name}} must be lower than {{maxSize}} |
| `inverted` | {{name}} must not be lower than {{maxSize}} |
| Mode | Template |
|------------|------------------------------------------------------------------------------------|
| `default` | {{name}} must be a filename or an instance of SplFileInfo or a PSR-7 interface |
| `inverted` | {{name}} must not be a filename or an instance of SplFileInfo or a PSR-7 interface |

## Template placeholders

| Placeholder | Description |
|-------------|------------------------------------------------------------------|
| `maxSize` | |
| `minSize` | |
| `name` | The validated input or the custom validator name (if specified). |
| `unit` | The name of the storage unit (bytes, kilobytes, etc.) |

## Categorization

- File system
- Transformations

## Changelog

| Version | Description |
|--------:|-------------------|
| 2.1.0 | Add PSR-7 support |
| 1.0.0 | Created |
| Version | Description |
|--------:|-------------------------|
| 3.0.0 | Became a transformation |
| 2.1.0 | Add [PSR-7][] support |
| 1.0.0 | Created |

***
See also:
Expand All @@ -88,3 +81,6 @@ See also:
- [SymbolicLink](SymbolicLink.md)
- [Uploaded](Uploaded.md)
- [Writable](Writable.md)

[PSR-7]: https://www.php-fig.org/psr/psr-7/
[SplFileInfo]: https://www.php.net/SplFileInfo
5 changes: 4 additions & 1 deletion library/Factory.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
use Respect\Validation\Transformers\DeprecatedKeyValue;
use Respect\Validation\Transformers\DeprecatedLength;
use Respect\Validation\Transformers\DeprecatedMinAndMax;
use Respect\Validation\Transformers\DeprecatedSize;
use Respect\Validation\Transformers\DeprecatedType;
use Respect\Validation\Transformers\Prefix;
use Respect\Validation\Transformers\RuleSpec;
Expand All @@ -44,7 +45,9 @@ public function __construct(
new DeprecatedKeyValue(
new DeprecatedMinAndMax(
new DeprecatedAge(
new DeprecatedKeyNested(new DeprecatedLength(new DeprecatedType(new Aliases(new Prefix()))))
new DeprecatedKeyNested(new DeprecatedLength(new DeprecatedType(new DeprecatedSize(
new Aliases(new Prefix())
))))
)
)
)
Expand Down
9 changes: 4 additions & 5 deletions library/Mixins/ChainedKey.php
Original file line number Diff line number Diff line change
Expand Up @@ -293,11 +293,10 @@ public function keyRoman(int|string $key): ChainedValidator;

public function keyScalarVal(int|string $key): ChainedValidator;

public function keySize(
int|string $key,
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function keySize(int|string $key, string $unit, Rule $rule): ChainedValidator;

public function keySlug(int|string $key): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/ChainedNot.php
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ public function notRoman(): ChainedValidator;

public function notScalarVal(): ChainedValidator;

public function notSize(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function notSize(string $unit, Rule $rule): ChainedValidator;

public function notSlug(): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/ChainedNullOr.php
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,10 @@ public function nullOrRoman(): ChainedValidator;

public function nullOrScalarVal(): ChainedValidator;

public function nullOrSize(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function nullOrSize(string $unit, Rule $rule): ChainedValidator;

public function nullOrSlug(): ChainedValidator;

Expand Down
9 changes: 4 additions & 5 deletions library/Mixins/ChainedProperty.php
Original file line number Diff line number Diff line change
Expand Up @@ -314,11 +314,10 @@ public function propertyRoman(string $propertyName): ChainedValidator;

public function propertyScalarVal(string $propertyName): ChainedValidator;

public function propertySize(
string $propertyName,
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function propertySize(string $propertyName, string $unit, Rule $rule): ChainedValidator;

public function propertySlug(string $propertyName): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/ChainedUndefOr.php
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,10 @@ public function undefOrRoman(): ChainedValidator;

public function undefOrScalarVal(): ChainedValidator;

public function undefOrSize(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function undefOrSize(string $unit, Rule $rule): ChainedValidator;

public function undefOrSlug(): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/ChainedValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,10 @@ public function roman(): ChainedValidator;

public function scalarVal(): ChainedValidator;

public function size(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public function size(string $unit, Rule $rule): ChainedValidator;

public function slug(): ChainedValidator;

Expand Down
9 changes: 4 additions & 5 deletions library/Mixins/StaticKey.php
Original file line number Diff line number Diff line change
Expand Up @@ -301,11 +301,10 @@ public static function keyRoman(int|string $key): ChainedValidator;

public static function keyScalarVal(int|string $key): ChainedValidator;

public static function keySize(
int|string $key,
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function keySize(int|string $key, string $unit, Rule $rule): ChainedValidator;

public static function keySlug(int|string $key): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/StaticNot.php
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,10 @@ public static function notRoman(): ChainedValidator;

public static function notScalarVal(): ChainedValidator;

public static function notSize(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function notSize(string $unit, Rule $rule): ChainedValidator;

public static function notSlug(): ChainedValidator;

Expand Down
8 changes: 4 additions & 4 deletions library/Mixins/StaticNullOr.php
Original file line number Diff line number Diff line change
Expand Up @@ -305,10 +305,10 @@ public static function nullOrRoman(): ChainedValidator;

public static function nullOrScalarVal(): ChainedValidator;

public static function nullOrSize(
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function nullOrSize(string $unit, Rule $rule): ChainedValidator;

public static function nullOrSlug(): ChainedValidator;

Expand Down
9 changes: 4 additions & 5 deletions library/Mixins/StaticProperty.php
Original file line number Diff line number Diff line change
Expand Up @@ -358,11 +358,10 @@ public static function propertyRoman(string $propertyName): ChainedValidator;

public static function propertyScalarVal(string $propertyName): ChainedValidator;

public static function propertySize(
string $propertyName,
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function propertySize(string $propertyName, string $unit, Rule $rule): ChainedValidator;

public static function propertySlug(string $propertyName): ChainedValidator;

Expand Down
8 changes: 4 additions & 4 deletions library/Mixins/StaticUndefOr.php
Original file line number Diff line number Diff line change
Expand Up @@ -303,10 +303,10 @@ public static function undefOrRoman(): ChainedValidator;

public static function undefOrScalarVal(): ChainedValidator;

public static function undefOrSize(
string|int|null $minSize = null,
string|int|null $maxSize = null,
): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function undefOrSize(string $unit, Rule $rule): ChainedValidator;

public static function undefOrSlug(): ChainedValidator;

Expand Down
5 changes: 4 additions & 1 deletion library/Mixins/StaticValidator.php
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,10 @@ public static function roman(): ChainedValidator;

public static function scalarVal(): ChainedValidator;

public static function size(string|int|null $minSize = null, string|int|null $maxSize = null): ChainedValidator;
/**
* @param "B"|"KB"|"MB"|"GB"|"TB"|"PB"|"EB"|"ZB"|"YB" $unit
*/
public static function size(string $unit, Rule $rule): ChainedValidator;

public static function slug(): ChainedValidator;

Expand Down
2 changes: 1 addition & 1 deletion library/Result.php
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public function withInput(mixed $input): self
return $this->clone(
input: $input,
children: array_map(
static fn (Result $child) => $child->input === $currentInput ? $input : $child->input,
static fn (Result $child) => $child->input === $currentInput ? $child->withInput($input) : $child,
$this->children
),
);
Expand Down
Loading
Loading