Support non consumable products #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
tonidero
force-pushed
the
rev-83-update-android-sdk-to-not-consume-in-app-purchase-when-the
branch
from
9d9c9bb
to
c5faffb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1697 +/- ##
==========================================
- Coverage 83.17% 83.12% -0.06%
==========================================
Files 221 222 +1
Lines 7555 7574 +19
Branches 1064 1070 +6
==========================================
+ Hits 6284 6296 +12
- Misses 851 854 +3
- Partials 420 424 +4 ☔ View full report in Codecov by Sentry. |
aboedo
reviewed
May 10, 2024
|
Backend has been merged. Would appreciate another review for this! |
aboedo
approved these changes
May 17, 2024
| } | ||
|
|
||
| @Test | ||
| fun `postTransactionAndConsumeIfNeeded tries to consume products if product data not available`() { |
aboedo
approved these changes
May 17, 2024
Comment on lines
10
to
11
| const val NOT_CONSUMING_IN_APP_PURCHASE_ACCORDING_TO_BACKEND = "Not consuming in-app purchase according to" + | ||
| " server configuration." |
There was a problem hiding this comment.
let's expand on the implications or maybe add a link to docs
There was a problem hiding this comment.
Don't have docs yet, but once we add it I will update this with that. Will update it briefly mentioning the consecuences though.
JayShortway
reviewed
May 17, 2024
purchases/src/main/kotlin/com/revenuecat/purchases/strings/PurchaseStrings.kt
Outdated
Show resolved
Hide resolved
…chaseStrings.kt Co-authored-by: JayShortway <29483617+JayShortway@users.noreply.github.com>
tonidero
deleted the
rev-83-update-android-sdk-to-not-consume-in-app-purchase-when-the
branch
tonidero
added a commit
that referenced
this pull request
May 20, 2024
### Description As part of the efforts to support non-consumables in android, we talked about not consuming IAPs when the backend returns a 4xx error. This should be an uncommon case but we don't want to miss the data in that case. This depends on the changes to support non-consumables in #1697
tonidero
added a commit
that referenced
this pull request
May 22, 2024
### Description Integration tests are failing on main due to the changes in #1697. This fixes those
vegaro
added a commit
that referenced
this pull request
May 29, 2024
After #1697 , we stopped consuming non-consumables if the backend indicates to not consume them. Non-consumables still need to be acknowledged, otherwise they get refunded, this PR fixes that. For reference, https://developer.android.com/google/play/billing/integrate#non-consumable-products
This was referenced May 29, 2024
vegaro
pushed a commit
that referenced
this pull request
May 30, 2024
**This is an automatic release.** ### New Features * Support non consumable products (#1697) via Toni Rico (@tonidero) ### Bugfixes * Fix non-consumables not getting acknowledged (#1709) via Cesar de la Vega (@vegaro) * Fix bad copy in log message (#1702) via Andy Boedo (@aboedo) ### Dependency Updates * Bump amazon SDK version to 3.0.5 (#1713) via Mark Villacampa (@MarkVillacampa) * Bump rexml from 3.2.6 to 3.2.8 (#1701) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072` (#1696) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix offline integration tests (#1704) via Toni Rico (@tonidero) * Do not consume IAPs when backend returns 4xx errors (#1699) via Toni Rico (@tonidero) * Update fastlane plugin and fix docs index path (#1695) via Toni Rico (@tonidero) * Add trigger_bump lane (#1692) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This brings support to non-consumables in android. The backend will let us know whether we need to consume a product after posting it or not.