Do not consume IAPs when backend returns 4xx errors #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
vegaro
approved these changes
May 9, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1699 +/- ##
==========================================
+ Coverage 83.07% 83.12% +0.05%
==========================================
Files 222 222
Lines 7581 7574 -7
Branches 1073 1070 -3
==========================================
- Hits 6298 6296 -2
+ Misses 857 854 -3
+ Partials 426 424 -2 ☔ View full report in Codecov by Sentry. |
aboedo
approved these changes
May 10, 2024
Base automatically changed from
rev-83-update-android-sdk-to-not-consume-in-app-purchase-when-the
to
main
May 17, 2024 15:32
tonidero
force-pushed
the
sdk-3441-do-not-consume-iaps-on-4xx-backend-errors
branch
from
ff8be45
to
24be329
Compare
This was referenced May 29, 2024
vegaro
pushed a commit
that referenced
this pull request
May 30, 2024
**This is an automatic release.** ### New Features * Support non consumable products (#1697) via Toni Rico (@tonidero) ### Bugfixes * Fix non-consumables not getting acknowledged (#1709) via Cesar de la Vega (@vegaro) * Fix bad copy in log message (#1702) via Andy Boedo (@aboedo) ### Dependency Updates * Bump amazon SDK version to 3.0.5 (#1713) via Mark Villacampa (@MarkVillacampa) * Bump rexml from 3.2.6 to 3.2.8 (#1701) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `dd5e21f` to `8ec0072` (#1696) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix offline integration tests (#1704) via Toni Rico (@tonidero) * Do not consume IAPs when backend returns 4xx errors (#1699) via Toni Rico (@tonidero) * Update fastlane plugin and fix docs index path (#1695) via Toni Rico (@tonidero) * Add trigger_bump lane (#1692) via Cesar de la Vega (@vegaro) Co-authored-by: revenuecat-ops <ops@revenuecat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the efforts to support non-consumables in android, we talked about not consuming IAPs when the backend returns a 4xx error. This should be an uncommon case but we don't want to miss the data in that case.
This depends on the changes to support non-consumables in #1697