Opening terms or privacy link from paywall opens in a sidebar on iPad

[stuart-j-williams]

• [ y] I have updated Purchases SDK to the latest version
• [y ] I have read the Contribution Guidelines
• [y ] I have searched the Community
• [y] I have read docs.revenuecat.com
• [y ] I have searched for existing Github issues

Describe the bug
When tapping on the terms or privacy link at the bottom of a paywall displayed in a sheet on an iPad results in a split-screen view with the content loading in the sidebar (see attached screenshot)

1. Environment
   1. Platform: iPadOS
   2. SDK version: 4.31.3
   3. StoreKit version:
      • StoreKit 1
      • StoreKit 2 (enabled with usesStoreKit2IfAvailable(true))
   4. OS version: 17.3 (21D5026f)
   5. Xcode version: 15.1 (15C65)
   6. Device and/or simulator:
      • Device
      • [x ] Simulator
   7. Environment:
      • [ x] Sandbox
      • TestFight
      • Production
   8. How widespread is the issue. Percentage of devices affected. 100% of iPad devices/simulators but only test devices as I don't have this version of the SDK in production yet
2. Debug logs that reproduce the issue. Complete logs with Purchases.logLevel = .verbose will help us debug this issue.
   Nothing appears in logs relating to this issue

Logs here

3. Steps to reproduce, with a description of expected vs. actual behavior

Tap the terms or privacy link at the bottom of a paywall and a split screen sheet appears with the content loaded in the sidebar. Should not load as split screen.

4. Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)

5. Additional context
   I've noticed that the incorrect behaviour only occurs when the paywall is displayed within a sheet and then launched through a NavigationLink

  Section {
            NavigationLink(destination: PaywallProductSelectionView(tabSelection: paywallTab), isActive: $showIAP) {
                HStack {
                    Image(systemName: "purchased").accessibilityHidden(true)
                    Text("Subscription Options")
                }.font(ai.body)
            }
            
        } header: {Text("In-app purchases").font(ai.sectionHeader) }

and then using the .paywallFooter option, e.g.

   .paywallFooter(offering: offering, condensed: isCondensed) { customerInfo in
            let entitlements = customerInfo.entitlements.active
            if entitlements.count > 0 {
                dismiss()
            }
        } restoreCompleted: { customerInfo in
            let entitlements = customerInfo.entitlements.active
            if entitlements.count > 0 {
                dismiss()
            }
        }

Seems to work fine when the paywall is just displayed in a sheet (which is ok for me on initial launch and purchase), but not when I re-display the paywall via a settings menu to allow the user to switch subscription tier.

[RCGitBot]

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

[NachoSoto]

Thanks for filing this! I'm still unable to reproduce. Where are you attaching the .paywallFooter modifier? It would help if you can provide some more code, it's not clear how your PaywallProductSelectionView connects to the paywall footer 🙏🏻

[stuart-j-williams]

Any chance we can continue this in a more private forum? I don’t want to paste larger sections of code into the public list. Also, perhaps you can provide some kind of config switch to revert to the browser link whilst we work through the issue? Thanks Stuart Williams

…

________________________________ From: NachoSoto ***@***.***> Sent: Thursday, December 14, 2023 6:40 pm To: RevenueCat/purchases-ios ***@***.***> Cc: Stuart Williams ***@***.***>; Author ***@***.***> Subject: Re: [RevenueCat/purchases-ios] Opening terms or privacy link from paywall opens in a sidebar on iPad (Issue #3518) Thanks for filing this! I'm still unable to reproduce. Where are you attaching the .paywallFooter modifier? It would help if you can provide some more code, it's not clear how your PaywallProductSelectionView connects to the paywall footer 🙏🏻 — Reply to this email directly, view it on GitHub<#3518 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUTVCASAJBXPQTFGW65VIJDYJM2YFAVCNFSM6AAAAABAUKWXGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJWGI4TSNBWGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[NachoSoto]

You could go back to version 4.31.2.

Mind sending me an e-mail? 🙏🏻 nacho@revenuecat.com
As soon as I can reproduce it I'll get a fix and we can release an update with it today.

[github-actions]

This issue has been automatically locked due to no recent activity after it was closed. Please open a new issue for related reports.