Paywalls: ensure footer links open in full-screen sheets
#3524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3524 +/- ##
=======================================
Coverage 85.97% 85.97%
=======================================
Files 240 240
Lines 17494 17494
=======================================
Hits 15041 15041
Misses 2453 2453 ☔ View full report in Codecov by Sentry. |
NachoSoto
changed the base branch from
main
to
paywalls-footer-text-alignment
NachoSoto
changed the base branch from
paywalls-footer-text-alignment
to
main
tonidero
approved these changes
Dec 19, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Dec 20, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: add `PaywallFooterViewController` (#3486) via Toni Rico (@tonidero) * `Paywalls`: improve landscape support of all templates (#3471) via NachoSoto (@NachoSoto) * `Paywalls`: ensure footer links open in full-screen sheets (#3524) via NachoSoto (@NachoSoto) * `Paywalls`: improve `FooterView` text alignment (#3525) via NachoSoto (@NachoSoto) * Paywalls: Add dismissal method in `PaywallViewControllerDelegate` (#3493) via Toni Rico (@tonidero)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3518.
Follow up to #3475 and #3508.