Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paywalls: adjusted German translations #3476

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Paywalls: adjusted German translations #3476

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed27106
`Paywalls`: adjusted German translations
tensei Nov 28, 2023
9d2de4a
Changed to .full only in the German localization
tensei Nov 29, 2023
39c1fc5
Added tests for German localization
tensei Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions RevenueCatUI/Data/Localization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,8 @@ private extension Localization {
switch locale.languageCodeIdentifier {
// Abbreviated does not fully work with Japanese
case "ja": return [.brief]
// Abbreviated is too short for German
case "de": return [.full, .brief]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more context for this change? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the German localization, .abbreviated only returns the first letter (see screenshot). I feel that even .brief might not be the best choice and should perhaps just be .full for German.

CleanShot 2023-11-28 at 17 27 39@2x

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is for the variable {{ price_per_period }} and {{ total_price_and_per_month }} in Paywalls

Weekly Before 9,99 €/Wo. Now no change
Monthly Before 9,99 €/M Now 9,99 €/Mon.
Yearly Before 9,99 €/J Now no change

default: return [.full, .brief, .abbreviated]
}
}
Expand Down
12 changes: 6 additions & 6 deletions RevenueCatUI/Resources/de.lproj/Localizable.strings
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
"OK" = "OK";
"All subscriptions" = "Alle Abonnements";
"Privacy" = "Privatsphäre";
"Privacy" = "Datenschutz";
"Privacy policy" = "Datenschutzrichtlinie";
"Purchases restored successfully!" = "Einkäufe erfolgreich wiederhergestellt!";
"Purchases restored successfully!" = "Käufe erfolgreich wiederhergestellt!";
"Restore" = "Wiederherstellen";
"Restore purchases" = "Einkäufe wiederherstellen";
"Restore purchases" = "Käufe wiederherstellen";
"Terms" = "Bedingungen";
"Terms and conditions" = "Geschäftsbedingungen";
"Terms and conditions" = "Nutzungsbedingungen";
"Annual" = "Jährlich";
"6 Month" = "6 Monate";
"3 Month" = "3 Monate";
"2 Month" = "2 Monate";
"Monthly" = "Monatlich";
"Weekly" = "Wöchentlich";
"Lifetime" = "Lebensdauer";
"Lifetime" = "Lebenslang";
"%d%% off" = "%d %% Rabatt";
"Continue" = "Weitermachen";
"Continue" = "Weiter";
"Default_offer_details_with_intro_offer" = "Starten Sie Ihre Testversion für {{ sub_offer_duration }} und dann für {{ total_price_and_per_month }}.";