Paywalls: adjusted German translations
#3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special abbreviation style for German
jefago
approved these changes
Nov 28, 2023
vegaro
reviewed
Nov 28, 2023
RevenueCatUI/Data/Localization.swift
Outdated
| @@ -164,6 +164,8 @@ private extension Localization { | |||
| switch locale.languageCodeIdentifier { | |||
| // Abbreviated does not fully work with Japanese | |||
| case "ja": return [.brief] | |||
| // Abbreviated is too short for German | |||
| case "de": return [.full, .brief] | |||
There was a problem hiding this comment.
Can you provide more context for this change? Thanks!
There was a problem hiding this comment.
In the German localization, .abbreviated only returns the first letter (see screenshot). I feel that even .brief might not be the best choice and should perhaps just be .full for German.
There was a problem hiding this comment.
This change is for the variable {{ price_per_period }} and {{ total_price_and_per_month }} in Paywalls
Weekly Before 9,99 €/Wo. Now no change
Monthly Before 9,99 €/M Now 9,99 €/Mon.
Yearly Before 9,99 €/J Now no change
|
This is great! Let's add tests like we have for Japanese :) |
|
Tests added 👍 |
NachoSoto
approved these changes
Dec 6, 2023
|
Thanks again! 🙏🏻 |
Merged
NachoSoto
added a commit
that referenced
this pull request
Dec 8, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Dec 12, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improve image caching (#3498) via NachoSoto (@NachoSoto) * `Paywalls`: change style of CTA button to be consistent with other platforms (#3507) via NachoSoto (@NachoSoto) * `Paywalls`: open footer links on Safari on Catalyst (#3508) via NachoSoto (@NachoSoto) * `Paywalls`: fix compilation on Xcode < 14.3 (#3513) via NachoSoto (@NachoSoto) * Fix typo in zh-Hans localization of RevenueCatUI (#3512) via Francis Feng (@francisfeng) * `Paywalls`: fix PaywallViewControllerDelegate access from Objective-C (#3510) via noncenz (@noncenz) * `Paywalls`: open Terms and Privacy Policy links in-app (#3475) via Andy Boedo (@aboedo) * `Paywalls`: fix empty description when using `custom` package type and `{{ sub_period }}` (#3495) via Andy Boedo (@aboedo) * `Paywalls`: use `HEIC` images (#3496) via NachoSoto (@NachoSoto) * Paywalls: disable the close button when an action is in progress (#3474) via Andy Boedo (@aboedo) * `Paywalls`: adjusted German translations (#3476) via Tensei (@tensei) * Paywalls: Improve Chinese localization (#3489) via Andy Boedo (@aboedo) ### Other Changes * `CircleCI`: add git credentials to snapshot generation (#3506) via NachoSoto (@NachoSoto) * `StoreProduct`: improve `priceFormatter` documentation (#3500) via NachoSoto (@NachoSoto) * `Paywalls`: fix tests (#3499) via NachoSoto (@NachoSoto) * `Optimization`: changed `first` to `first(where:)` (#3467) via NachoSoto (@NachoSoto)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special abbreviation style for German and some corrections to the German translation
Motivation
Just fixing/adjusting some stuff for all germans
Description
The updated translations are more precise. For instance, "Datenschutz" is a more commonly used term for "Privacy" in German. Similarly, changing "Lebensdauer" to "Lebenslang" for "Lifetime" is more accurate, as "Lebenslang" specifically implies 'for life'. The other changes follow a similar pattern of refining the language for better comprehension and context-appropriate usage in German.