Paywalls: Improve Chinese localization #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Andy. This is Francis Feng.
No, my app only has a monthly plan (no plans for 2, 3, 6 months). But the paywall shows up as “¥15/个月”. I also updated some strings here #3490. |
tonidero
approved these changes
Dec 5, 2023
### Motivation Resolves #3489 ### Description Another issue I found after looking at the [Localizable.strings](https://github.com/RevenueCat/purchases-ios/pull/3489/files): You can’t directly translate "%d%% off” as "%d%%折” in Chinese. In Chinese, if one item is 20% off, we say it’s “8折” (8 comes from (1-20%)*10). So if you insist on this translation you will need to change the related code. I would suggest you to simply translate "%d%% off" as "优惠%d%%"(Simplified Chinese) and "優惠%d%%" (Traditional Chinese), which aligns with the word ”off”. Last issue regarding formatting: "Default_offer_details_with_intro_offer" = "开始 {{ sub_offer_duration }} 试用，然后 {{total_price_and_per_month }}。"; I don’t think we need spaces around “{{ sub_offer_duration }}” and ”{{total_price_and_per_month }}”.
|
@francisfeng thanks so much again for opening up the PR and bringing this up in the first place! |
|
I'm not sure how we're getting the |
It comes from the variable
|
NachoSoto
approved these changes
Dec 5, 2023
| "Continue" = "繼續"; | ||
| "Default_offer_details_with_intro_offer" = "開始 {{ sub_offer_duration }} 試用，然後 {{total_price_and_per_month }}。"; |
greenietea
approved these changes
Dec 6, 2023
Co-authored-by: Greenie <greenie.cheng@gmail.com>
Co-authored-by: Greenie <greenie.cheng@gmail.com>
Co-authored-by: Greenie <greenie.cheng@gmail.com>
Co-authored-by: Greenie <greenie.cheng@gmail.com>
Co-authored-by: Greenie <greenie.cheng@gmail.com>
Co-authored-by: Greenie <greenie.cheng@gmail.com>
|
@greenietea thanks for the suggestions!! 🙌 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3489 +/- ##
==========================================
- Coverage 86.06% 86.06% -0.01%
==========================================
Files 237 237
Lines 17211 17211
==========================================
- Hits 14813 14812 -1
- Misses 2398 2399 +1 ☔ View full report in Codecov by Sentry. |
aboedo
deleted the
andy/deng-621-incorrect-translations-for-paywall-chinese-localization
branch
NachoSoto
pushed a commit
that referenced
this pull request
Dec 12, 2023
**This is an automatic release.** ### RevenueCatUI * `Paywalls`: improve image caching (#3498) via NachoSoto (@NachoSoto) * `Paywalls`: change style of CTA button to be consistent with other platforms (#3507) via NachoSoto (@NachoSoto) * `Paywalls`: open footer links on Safari on Catalyst (#3508) via NachoSoto (@NachoSoto) * `Paywalls`: fix compilation on Xcode < 14.3 (#3513) via NachoSoto (@NachoSoto) * Fix typo in zh-Hans localization of RevenueCatUI (#3512) via Francis Feng (@francisfeng) * `Paywalls`: fix PaywallViewControllerDelegate access from Objective-C (#3510) via noncenz (@noncenz) * `Paywalls`: open Terms and Privacy Policy links in-app (#3475) via Andy Boedo (@aboedo) * `Paywalls`: fix empty description when using `custom` package type and `{{ sub_period }}` (#3495) via Andy Boedo (@aboedo) * `Paywalls`: use `HEIC` images (#3496) via NachoSoto (@NachoSoto) * Paywalls: disable the close button when an action is in progress (#3474) via Andy Boedo (@aboedo) * `Paywalls`: adjusted German translations (#3476) via Tensei (@tensei) * Paywalls: Improve Chinese localization (#3489) via Andy Boedo (@aboedo) ### Other Changes * `CircleCI`: add git credentials to snapshot generation (#3506) via NachoSoto (@NachoSoto) * `StoreProduct`: improve `priceFormatter` documentation (#3500) via NachoSoto (@NachoSoto) * `Paywalls`: fix tests (#3499) via NachoSoto (@NachoSoto) * `Optimization`: changed `first` to `first(where:)` (#3467) via NachoSoto (@NachoSoto)
aboedo
added a commit
to RevenueCat/purchases-android
that referenced
this pull request
Dec 21, 2023
Android equivalent to RevenueCat/purchases-ios#3489 I noticed that we don't have a separate file for Chinese Simplified on Android? Is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements to Chinese Traditional and Chinese Simplified localizations based on user feedback.