Improve price per month accuracy for weekly subscriptions #3480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eks per month being 4.345 instead of 4.0
tonidero
approved these changes
Nov 30, 2023
tonidero
added a commit
that referenced
this pull request
Dec 5, 2023
### Description Followup to #3480 This slightly improves precision when calculating price per year for weekly subscriptions.
NachoSoto
pushed a commit
that referenced
this pull request
Dec 6, 2023
**This is an automatic release.** ### Bugfixes * Improve pricePerYear price calculation precision (#3492) via Toni Rico (@tonidero) * Improve price per month accuracy for weekly subscriptions (#3480) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.0 to 9.4.1 (#3485) via dependabot[bot] (@dependabot[bot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were calculating the price per month for weekly products as price * 4, but there are on average 4.345 weeks in a month, so this updates the value accordingly.