Improve pricePerYear price calculation precision #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 237 237
Lines 17211 17211
=======================================
+ Hits 14812 14813 +1
+ Misses 2399 2398 -1 ☔ View full report in Codecov by Sentry. |
vegaro
approved these changes
Dec 5, 2023
NachoSoto
pushed a commit
that referenced
this pull request
Dec 6, 2023
**This is an automatic release.** ### Bugfixes * Improve pricePerYear price calculation precision (#3492) via Toni Rico (@tonidero) * Improve price per month accuracy for weekly subscriptions (#3480) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.0 to 9.4.1 (#3485) via dependabot[bot] (@dependabot[bot])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Followup to #3480
This slightly improves precision when calculating price per year for weekly subscriptions.