Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 #3615

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 #3615

merged 6 commits into from
Feb 7, 2024

Conversation

NachoSoto
Copy link
Contributor

@NachoSoto NachoSoto commented Jan 30, 2024 •
edited
Loading

@NachoSoto NachoSoto added HOLD pr:breaking Changes that are breaking labels Jan 30, 2024
@NachoSoto NachoSoto requested a review from a team January 30, 2024 20:50
NachoSoto added a commit that referenced this pull request Jan 30, 2024
@NachoSoto
Remove redundant @available annotations
4deef30 
Follow up to #3615.
@NachoSoto NachoSoto mentioned this pull request Jan 30, 2024
Merged
NachoSoto added a commit that referenced this pull request Jan 30, 2024
@NachoSoto
Remove redundant @available annotations
2c818ec 
Follow up to #3615.
@NachoSoto
Copy link
Contributor Author

Holding until we're ready to release the major with #3582 and #3529.

NachoSoto added a commit that referenced this pull request Jan 30, 2024
@NachoSoto
Remove redundant @available annotations
ccff79a 
Follow up to #3615.
NachoSoto added a commit that referenced this pull request Jan 30, 2024
@NachoSoto
Remove redundant @available annotations
2217344 
Follow up to #3615.
@NachoSoto NachoSoto force-pushed the deployment-target-ios-13 branch from 34805a8 to 4d40e03 Compare February 1, 2024 16:07
NachoSoto added a commit that referenced this pull request Feb 1, 2024
@NachoSoto
Remove redundant @available annotations
d42f89b 
Follow up to #3615.
@NachoSoto NachoSoto mentioned this pull request Feb 5, 2024
Merged
MarkVillacampa
MarkVillacampa approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@MarkVillacampa MarkVillacampa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY!

@NachoSoto NachoSoto mentioned this pull request Feb 7, 2024
Closed
@MarkVillacampa
Copy link
Member

iOS 15 tests seem to be failing consistently here:

Testing failed:
        UnitTestsHostApp (8762) encountered an error (Early unexpected exit, operation never finished bootstrapping - no restart will be attempted. (Underlying Error: Crash: UnitTestsHostApp (8762) type metadata completion function for MockStoreMessage. If you believe this error represents a bug, please attach the result bundle at /Users/distiller/purchases-ios/fastlane/test_output/xctest/ios/RevenueCat.xcresult))

@NachoSoto NachoSoto changed the base branch from main to mock-message-crash February 7, 2024 16:58
@NachoSoto NachoSoto force-pushed the deployment-target-ios-13 branch from 4d40e03 to 3d26f18 Compare February 7, 2024 16:58
@NachoSoto
Copy link
Contributor Author

I just rebased this off of #3650 which I think will fix that.

@MarkVillacampa MarkVillacampa changed the base branch from mock-message-crash to 5.0-dev February 7, 2024 17:57
NachoSoto added a commit that referenced this pull request Feb 7, 2024
@NachoSoto
Remove redundant @available annotations
a471a41 
Follow up to #3615.
@NachoSoto NachoSoto removed the HOLD label Feb 7, 2024
@NachoSoto
Copy link
Contributor Author

@MarkVillacampa feel free to merge this :)

@MarkVillacampa MarkVillacampa enabled auto-merge (squash) February 7, 2024 18:51
@MarkVillacampa MarkVillacampa merged commit 1f76bb7 into 5.0-dev Feb 7, 2024
24 checks passed
NachoSoto added a commit that referenced this pull request Feb 7, 2024
@NachoSoto
Remove redundant @available annotations
f1a0bb1 
Follow up to #3615.
NachoSoto added a commit that referenced this pull request Feb 7, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
4f35989 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
41addfc 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
NachoSoto added a commit that referenced this pull request Feb 9, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
5c3e6c4 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
9a1f90a 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
3d3c3a3 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
338a392 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
1b4786f 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
e711cc5 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
NachoSoto added a commit that referenced this pull request Feb 12, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
9162187 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
NachoSoto added a commit that referenced this pull request Feb 14, 2024
@NachoSoto
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
f04d60d 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
NachoSoto added a commit that referenced this pull request Feb 14, 2024
@NachoSoto
Remove redundant @available and #available annotations (#3616)
5aef999 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
MarkVillacampa pushed a commit that referenced this pull request Feb 21, 2024
@NachoSoto @MarkVillacampa
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
e4ddf4a 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
MarkVillacampa pushed a commit that referenced this pull request Feb 21, 2024
@NachoSoto @MarkVillacampa
Remove redundant @available and #available annotations (#3616)
c0d6c6b 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
joshdholtz pushed a commit that referenced this pull request Feb 23, 2024
@NachoSoto @joshdholtz
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
26734a0 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
joshdholtz pushed a commit that referenced this pull request Feb 23, 2024
@NachoSoto @joshdholtz
Remove redundant @available and #available annotations (#3616)
6e33d57 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
MarkVillacampa pushed a commit that referenced this pull request Mar 6, 2024
@NachoSoto @MarkVillacampa
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
093f640 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
MarkVillacampa pushed a commit that referenced this pull request Mar 6, 2024
@NachoSoto @MarkVillacampa
Remove redundant @available and #available annotations (#3616)
feb5b46 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
MarkVillacampa pushed a commit that referenced this pull request Mar 6, 2024
@NachoSoto @MarkVillacampa
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
a63da73 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
MarkVillacampa pushed a commit that referenced this pull request Mar 6, 2024
@NachoSoto @MarkVillacampa
Remove redundant @available and #available annotations (#3616)
97cb092 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
MarkVillacampa pushed a commit that referenced this pull request Apr 9, 2024
@NachoSoto @MarkVillacampa
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
a00aa10 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
MarkVillacampa pushed a commit that referenced this pull request Apr 9, 2024
@NachoSoto @MarkVillacampa
Remove redundant @available and #available annotations (#3616)
8c5db55 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
fire-at-will pushed a commit that referenced this pull request Apr 15, 2024
@NachoSoto @fire-at-will
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
00bd8b1 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

### After this PR:
- #3616 
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
fire-at-will pushed a commit that referenced this pull request Apr 15, 2024
@NachoSoto @fire-at-will
Remove redundant @available and #available annotations (#3616)
ee3991d 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
fire-at-will pushed a commit that referenced this pull request May 13, 2024
@NachoSoto @fire-at-will
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
0a5a139 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

- #3616
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
fire-at-will pushed a commit that referenced this pull request May 13, 2024
@NachoSoto @fire-at-will
Remove redundant @available and #available annotations (#3616)
7270680 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
fire-at-will pushed a commit that referenced this pull request Jun 24, 2024
@NachoSoto @fire-at-will
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
6d72555 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

- #3616
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
fire-at-will pushed a commit that referenced this pull request Jun 24, 2024
@NachoSoto @fire-at-will
Remove redundant @available and #available annotations (#3616)
9139775 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
fire-at-will pushed a commit that referenced this pull request Jun 28, 2024
@NachoSoto @fire-at-will
Bump deployment target to iOS 13 / tvOS 13 / macOS 10.15 (#3615)
89ae00c 
See
https://github.com/RevenueCat/purchases-ios/blob/1fd2736217c94ec025f5e44724f978505f4a84c0/Contributing/UpdatingRequirements.md

- #3616
- Update deployment target on PHC and hybrids
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/ios.md
- Update
https://github.com/RevenueCat/revenuecat-docs/blob/main/docs_source/Getting%20Started/installation/macos.md
fire-at-will pushed a commit that referenced this pull request Jun 28, 2024
@NachoSoto @fire-at-will
Remove redundant @available and #available annotations (#3616)
30c07c1 
Follow up to #3615.

![Screenshot 2024-01-30 at 13 19
21](https://github.com/RevenueCat/purchases-ios/assets/685609/731cc254-8c25-4b6b-bb46-b0bf62405ede)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkVillacampa MarkVillacampa MarkVillacampa approved these changes

Assignees
No one assigned
Labels
pr:breaking Changes that are breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NachoSoto @MarkVillacampa