Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/5.0.0-beta.2 #3645

Closed
wants to merge 3 commits into from
Closed

Release/5.0.0-beta.2 #3645

wants to merge 3 commits into from

Conversation

MarkVillacampa
Copy link
Member

@MarkVillacampa MarkVillacampa commented Feb 6, 2024

No description provided.

@NachoSoto
Copy link
Contributor

Maybe remove what's already coming out on #3644?

FileUtils.cp docs_migration_guide_path, migration_guide_destination_path
docs_files.each do |file|
FileUtils.cp file, "docs/"
end
Copy link
Member Author

@MarkVillacampa MarkVillacampa Feb 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a new file here so took the opportunity to generalize this so we don't need to add new files manually.

@NachoSoto
Copy link
Contributor

Reminder to bring #3582, #3583, and #3615 if you can 🙏🏻

@MarkVillacampa MarkVillacampa changed the base branch from main to 5.0-dev February 7, 2024 19:21
@MarkVillacampa
Copy link
Member Author

MarkVillacampa commented Feb 7, 2024

Rebased on top of #3652

@MarkVillacampa
Copy link
Member Author

This has been released.

Created #3658 to add the changelog + migration guide to the 5.0-dev branch.

Closing this instead of merging to avoid future merge conflicts with the version change commits.

@vegaro vegaro deleted the release/5.0.0-beta.2 branch March 21, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants