Paywalls: new presentationMode parameter (by @Lascorbe)
#3638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### TLDR - Added a way to present `PaywallView` either as sheet or full screen - No breaking changes have been made ### Motivation I wanted to easily present the PaywallView on full screen. ### Description I added a new enum `PaywallPresentationMode` which currently has 2 options: `.sheet` and `.fullScreen `. I added this as a parameter to the current public `presentPaywallIfNeeded` modifiers. The default is `sheet` so there are no breaking changes with the current public API. | Sheet | Full Screen | | ------------- | ------------- | |  |  | PD: I looked for info on how to contribute but it's unclear if I have to open an issue first or not (contributing says open issue, then when opening an issue it says please don't open but contact us at https://app.revenuecat.com/settings/support). I hope this is valid, otherwise let me know how I can proceed. --------- Co-authored-by: Luis Ascorbe <luis@caribepixels.com> Co-authored-by: NachoSoto <NachoSoto@users.noreply.github.com>
NachoSoto
force-pushed
the
presentation-mode
branch
from
9da78de
to
57d070e
Compare
tonidero
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
Oh nice addition! I was thinking whether this could apply to Android, but we're already presenting it as full screen when using the PaywallActivityLauncher. With the PaywallDialog composable we are full screen on mobile, and modal on tablets, but people can always use the Paywall composable directly if they have to, so I think we should be fine there.
NachoSoto
force-pushed
the
presentation-mode
branch
2 times, most recently
from
39c0c4c
to
eacefc8
Compare
|
Yeah I think this is sort of specific to this platform where SwiftUI offers these 2 options. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #3632 by Lascorbe.
TLDR
PaywallVieweither as sheet or full screenMotivation
I wanted to easily present the PaywallView on full screen.
Description
I added a new enum
PaywallPresentationModewhich currently has 2 options:.sheetand.fullScreen. I added this as a parameter to the current public.presentPaywallIfNeededmodifiers. The default issheetso there are no breaking changes with the current public API.