Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NonSubscriptionTransaction: expose storeTransactionIdentifier #3639

Merged
merged 1 commit into from
Feb 6, 2024
Merged

NonSubscriptionTransaction: expose storeTransactionIdentifier #3639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/Purchasing/NonSubscriptionTransaction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public final class NonSubscriptionTransaction: NSObject {
@objc public let transactionIdentifier: String

/// The unique identifier for the transaction created by the Store.
@objc internal let storeTransactionIdentifier: String
@objc public let storeTransactionIdentifier: String
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm only slightly concerned about the confussion of having both ids... but I think it shoud be ok?


init?(with transaction: CustomerInfoResponse.Transaction, productID: String) {
guard let transactionIdentifier = transaction.transactionIdentifier,
Expand Down
1 change: 1 addition & 0 deletions Tests/APITesters/ObjCAPITester/ObjCAPITester/RCNonSubscriptionTransactionAPI.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ + (void)checkAPI {
NSString *pid __unused = transaction.productIdentifier;
NSDate *pd __unused = transaction.purchaseDate;
NSString *tid __unused = transaction.transactionIdentifier;
NSString *stid __unused = transaction.storeTransactionIdentifier;
}

@end
1 change: 1 addition & 0 deletions Tests/APITesters/SwiftAPITester/SwiftAPITester/NonSubscriptionTransactionAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ func checkNonSubscriptionTransactionAPI() {
let _: String = transaction.productIdentifier
let _: Date = transaction.purchaseDate
let _: String = transaction.transactionIdentifier
let _: String = transaction.storeTransactionIdentifier
}