NonSubscriptionTransaction: expose storeTransactionIdentifier
#3639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboedo you pointed out in #3009 (comment) that you wouldn't make it You mentioned:
But we do expose it when purchasing through |
tonidero
approved these changes
Feb 6, 2024
| @@ -32,7 +32,7 @@ public final class NonSubscriptionTransaction: NSObject { | |||
| @objc public let transactionIdentifier: String | |||
|
|
|||
| /// The unique identifier for the transaction created by the Store. | |||
| @objc internal let storeTransactionIdentifier: String | |||
| @objc public let storeTransactionIdentifier: String | |||
There was a problem hiding this comment.
I'm only slightly concerned about the confussion of having both ids... but I think it shoud be ok?
aboedo
approved these changes
Feb 6, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3636.
This was added in #3009.
It was not made
publicbecause it was only used for #2841, but as explained in #3636 it can be useful aspublic.