Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clone to spm using fastlane #3926

Merged
merged 18 commits into from
Jun 18, 2024
Merged

Clone to spm using fastlane #3926

merged 18 commits into from
Jun 18, 2024

Conversation

jamesrb1
Copy link
Contributor

@jamesrb1 jamesrb1 commented May 30, 2024

This moves the logic for cloning the repo out of the CircleCI .yml file to a new fastlane lane.

Companion PR: RevenueCat/fastlane-plugin-revenuecat_internal#65

jamesrb1 added 4 commits May 30, 2024 16:41
So that the git commands can be removed from the .yml file. This commit contains test targets (sync-to-spm-repo branch and spm3.git).
@jamesrb1 jamesrb1 changed the title James/clone to spm in fastlane [WIP] clone to spm in fastlane May 30, 2024
@jamesrb1 jamesrb1 changed the title [WIP] clone to spm in fastlane Clone to spm using fastlane May 31, 2024
@jamesrb1 jamesrb1 added the build label Jun 3, 2024
@jamesrb1 jamesrb1 marked this pull request as ready for review June 3, 2024 18:12
@jamesrb1 jamesrb1 requested a review from a team June 3, 2024 18:12
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion but looks good!

fastlane/Fastfile Outdated Show resolved Hide resolved
docker:
- image: cimg/base:stable
resource_class: small
<<: *base-job
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base job is a Mac machine. Can we use something that's faster/cheaper? Maybe a ruby docker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that before (cb9a4d8) but was hitting problems, will try again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jamesrb1 jamesrb1 enabled auto-merge (squash) June 18, 2024 19:17
@jamesrb1 jamesrb1 merged commit 5331ce9 into main Jun 18, 2024
24 checks passed
@jamesrb1 jamesrb1 deleted the james/clone-to-spm-in-fastlane branch June 18, 2024 20:06
jamesrb1 added a commit that referenced this pull request Jun 19, 2024
This moves the logic for cloning the repo out of the CircleCI .yml file
to a new fastlane lane.

Companion PR:
RevenueCat/fastlane-plugin-revenuecat_internal#65
tonidero pushed a commit that referenced this pull request Jun 21, 2024
**This is an automatic release.**

### Dependency Updates
* Bump fastlane from 2.220.0 to 2.221.0 (#3971) via dependabot[bot]
(@dependabot[bot])
* Bump rexml from 3.2.6 to 3.2.8 (#3907) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `8ec0072` to `5f55466`
(#3938) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Fix cocoapods installation tests (#3981) via Toni Rico (@tonidero)
* Remove carthage from CI and update release jobs to use xcode 15 and M1
(#3927) via Cesar de la Vega (@vegaro)
* Bring back offline integration tests on M1 (#3976) via Toni Rico
(@tonidero)
* Fix Carthage (#3978) via James Borthwick (@jamesrb1)
* Revert "Run offline backend integration tests on M1 machines (#3961)"
(#3974) via Toni Rico (@tonidero)
* Run offline backend integration tests on M1 machines (#3961) via Toni
Rico (@tonidero)
* Xcode project with RevenueCatUI + Tests (#3960) via James Borthwick
(@jamesrb1)
* Clone to spm using fastlane (#3926) via James Borthwick (@jamesrb1)
* finishTransactions/ObserverMode -> PurchasesAreCompletedBy (#3947) via
James Borthwick (@jamesrb1)
* Switch tests for iOS 12 and 13 to M1 (#3958) via Toni Rico (@tonidero)
* Fix prepare next version job (#3939) via Toni Rico (@tonidero)
nyeu pushed a commit that referenced this pull request Oct 2, 2024
This moves the logic for cloning the repo out of the CircleCI .yml file
to a new fastlane lane.

Companion PR:
RevenueCat/fastlane-plugin-revenuecat_internal#65
nyeu pushed a commit that referenced this pull request Oct 2, 2024
**This is an automatic release.**

### Dependency Updates
* Bump fastlane from 2.220.0 to 2.221.0 (#3971) via dependabot[bot]
(@dependabot[bot])
* Bump rexml from 3.2.6 to 3.2.8 (#3907) via dependabot[bot]
(@dependabot[bot])
* Bump fastlane-plugin-revenuecat_internal from `8ec0072` to `5f55466`
(#3938) via dependabot[bot] (@dependabot[bot])
### Other Changes
* Fix cocoapods installation tests (#3981) via Toni Rico (@tonidero)
* Remove carthage from CI and update release jobs to use xcode 15 and M1
(#3927) via Cesar de la Vega (@vegaro)
* Bring back offline integration tests on M1 (#3976) via Toni Rico
(@tonidero)
* Fix Carthage (#3978) via James Borthwick (@jamesrb1)
* Revert "Run offline backend integration tests on M1 machines (#3961)"
(#3974) via Toni Rico (@tonidero)
* Run offline backend integration tests on M1 machines (#3961) via Toni
Rico (@tonidero)
* Xcode project with RevenueCatUI + Tests (#3960) via James Borthwick
(@jamesrb1)
* Clone to spm using fastlane (#3926) via James Borthwick (@jamesrb1)
* finishTransactions/ObserverMode -> PurchasesAreCompletedBy (#3947) via
James Borthwick (@jamesrb1)
* Switch tests for iOS 12 and 13 to M1 (#3958) via Toni Rico (@tonidero)
* Fix prepare next version job (#3939) via Toni Rico (@tonidero)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants