Fix Carthage #3978
Merged
Fix Carthage #3978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
approved these changes
Jun 20, 2024
| # Carthage builds all schemes including ones we don't need, so let's nuke them before proceeding | ||
| schemes_directory = "Carthage/Checkouts/purchases-root/RevenueCat.xcodeproj/xcshareddata/xcschemes" | ||
| Dir.glob("#{schemes_directory}/*.xcscheme").each do |file_path| | ||
| next if File.basename(file_path) == "RevenueCat.xcscheme" |
There was a problem hiding this comment.
does this mean that we're skipping the test for RevenueCatUI?
There was a problem hiding this comment.
RevenueCatUI scheme is only defined in the Package file, which is ignored by Carthage.
There was a problem hiding this comment.
Oh wait that might be wrong, it's there but not shown? Anyway, this is the directory it searches, so it shouldn't affect RevenueCatUI.
jamesborthwick@Jamess-MacBook-Pro-2 xcschemes % ls -l
total 48
-rw-r--r--@ 1 jamesborthwick staff 4978 13 Apr 14:02 BackendIntegrationTests.xcscheme
-rw-r--r--@ 1 jamesborthwick staff 3591 13 Apr 14:02 ReceiptParser.xcscheme
-rw-r--r--@ 1 jamesborthwick staff 7220 14 Jun 14:47 RevenueCat.xcscheme
-rw-r--r--@ 1 jamesborthwick staff 2609 20 Jun 10:21 RevenueCatUIDev.xcscheme
This was referenced Jun 21, 2024
tonidero
pushed a commit
that referenced
this pull request
Jun 21, 2024
**This is an automatic release.** ### Dependency Updates * Bump fastlane from 2.220.0 to 2.221.0 (#3971) via dependabot[bot] (@dependabot[bot]) * Bump rexml from 3.2.6 to 3.2.8 (#3907) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `8ec0072` to `5f55466` (#3938) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix cocoapods installation tests (#3981) via Toni Rico (@tonidero) * Remove carthage from CI and update release jobs to use xcode 15 and M1 (#3927) via Cesar de la Vega (@vegaro) * Bring back offline integration tests on M1 (#3976) via Toni Rico (@tonidero) * Fix Carthage (#3978) via James Borthwick (@jamesrb1) * Revert "Run offline backend integration tests on M1 machines (#3961)" (#3974) via Toni Rico (@tonidero) * Run offline backend integration tests on M1 machines (#3961) via Toni Rico (@tonidero) * Xcode project with RevenueCatUI + Tests (#3960) via James Borthwick (@jamesrb1) * Clone to spm using fastlane (#3926) via James Borthwick (@jamesrb1) * finishTransactions/ObserverMode -> PurchasesAreCompletedBy (#3947) via James Borthwick (@jamesrb1) * Switch tests for iOS 12 and 13 to M1 (#3958) via Toni Rico (@tonidero) * Fix prepare next version job (#3939) via Toni Rico (@tonidero)
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Deletes all non-"RevenueCat" schemes in the project's shared folder (currently `BackendIntegrationTests.xcscheme `, `ReceiptParser.xcscheme ` and `RevenueCatUIDev.xcscheme `, which I assume are not needed by Carthage, so this should save a bit of time over what it was doing before too because it won't spend time on them.
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ### Dependency Updates * Bump fastlane from 2.220.0 to 2.221.0 (#3971) via dependabot[bot] (@dependabot[bot]) * Bump rexml from 3.2.6 to 3.2.8 (#3907) via dependabot[bot] (@dependabot[bot]) * Bump fastlane-plugin-revenuecat_internal from `8ec0072` to `5f55466` (#3938) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Fix cocoapods installation tests (#3981) via Toni Rico (@tonidero) * Remove carthage from CI and update release jobs to use xcode 15 and M1 (#3927) via Cesar de la Vega (@vegaro) * Bring back offline integration tests on M1 (#3976) via Toni Rico (@tonidero) * Fix Carthage (#3978) via James Borthwick (@jamesrb1) * Revert "Run offline backend integration tests on M1 machines (#3961)" (#3974) via Toni Rico (@tonidero) * Run offline backend integration tests on M1 machines (#3961) via Toni Rico (@tonidero) * Xcode project with RevenueCatUI + Tests (#3960) via James Borthwick (@jamesrb1) * Clone to spm using fastlane (#3926) via James Borthwick (@jamesrb1) * finishTransactions/ObserverMode -> PurchasesAreCompletedBy (#3947) via James Borthwick (@jamesrb1) * Switch tests for iOS 12 and 13 to M1 (#3958) via Toni Rico (@tonidero) * Fix prepare next version job (#3939) via Toni Rico (@tonidero)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It deletes all non-RevenueCat schemes which I assume are not needed by Carthage, so this should save a bit of time over what it was doing before too because it won't spend time on them.
https://app.circleci.com/pipelines/github/RevenueCat/purchases-ios/19899/workflows/a895e06e-305d-439d-9f99-3047a0375594