Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customer Center] Add API call to get Customer Center config #3933

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented May 31, 2024

Adds Purchases.shared.loadCustomerCenter() that calls a new backend endpoint that returns the customer center configuration

This API call doesn't exist yet and it will change. This PR is the ground work so that we don't have to wait for the backend to add this API and we can already pretend the API is there.

@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from 9423df6 to c350297 Compare June 4, 2024 12:44
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch 2 times, most recently from 26fb266 to abb1c50 Compare June 13, 2024 14:59
@vegaro vegaro changed the title [Customer Center Workflow] Add endpoint (hardcoded for now) [Customer Center Workflow] Add call to backend Jun 13, 2024
@vegaro
Copy link
Contributor Author

vegaro commented Jun 17, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vegaro and the rest of your teammates on Graphite Graphite

@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from 8957234 to 2f36ec7 Compare June 17, 2024 12:33
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from 2f36ec7 to 2d41724 Compare June 17, 2024 12:43
@vegaro vegaro marked this pull request as ready for review June 17, 2024 12:45
@vegaro vegaro changed the title [Customer Center Workflow] Add call to backend [Customer Center] Add API call to get Customer Center config Jun 17, 2024
@vegaro vegaro requested a review from a team June 17, 2024 12:47
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I would probably hold off merging back to main until the feature is ready in case the public API changes (or we can make it internal until everything is ready).

Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we are missing tests? Not sure if we are doing those in a separate PR though

@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch 3 times, most recently from ad260d3 to 3dd2fb0 Compare June 26, 2024 14:45
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from 3dd2fb0 to 821016e Compare June 27, 2024 10:15
Base automatically changed from sdk-3433-supportview to integration/customer_support_workflow June 28, 2024 10:16
@vegaro vegaro force-pushed the integration/customer_support_workflow branch from 4ab05c3 to 5fcbe86 Compare June 28, 2024 10:19
@vegaro vegaro force-pushed the integration/customer_support_workflow branch from 202b5c6 to 3467940 Compare July 8, 2024 19:52
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from 4bbc8de to 7268b6f Compare July 8, 2024 19:52
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch 3 times, most recently from 3dcc74f to e0b4ea4 Compare July 9, 2024 15:13
@vegaro vegaro force-pushed the sdk-3472-add-hardcoded-response-to-sdk branch from e0b4ea4 to 93ccbc5 Compare July 9, 2024 18:32
@vegaro vegaro merged commit 8099f65 into integration/customer_support_workflow Jul 9, 2024
26 checks passed
@vegaro vegaro deleted the sdk-3472-add-hardcoded-response-to-sdk branch July 9, 2024 19:48
vegaro added a commit that referenced this pull request Jul 9, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend
endpoint that returns the customer center configuration

This API call doesn't exist yet and it will change. This PR is the
ground work so that we don't have to wait for the backend to add this
API and we can already pretend the API is there.

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro added a commit that referenced this pull request Jul 11, 2024
Based off #3933 



https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09

Can probably use some animations, but tuning that up will come up later

It will open a feedback survey for an option if there's one
vegaro added a commit that referenced this pull request Jul 15, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend
endpoint that returns the customer center configuration

This API call doesn't exist yet and it will change. This PR is the
ground work so that we don't have to wait for the backend to add this
API and we can already pretend the API is there.

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro added a commit that referenced this pull request Jul 15, 2024
Based off #3933 



https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09

Can probably use some animations, but tuning that up will come up later

It will open a feedback survey for an option if there's one
vegaro added a commit that referenced this pull request Jul 17, 2024
Adds `Purchases.shared.loadCustomerCenter()` that calls a new backend
endpoint that returns the customer center configuration

This API call doesn't exist yet and it will change. This PR is the
ground work so that we don't have to wait for the backend to add this
API and we can already pretend the API is there.

---------

Co-authored-by: RevenueCat Git Bot <72824662+RCGitBot@users.noreply.github.com>
vegaro added a commit that referenced this pull request Jul 17, 2024
Based off #3933 



https://github.com/RevenueCat/purchases-ios/assets/664544/11eae984-294a-4e14-8c40-7c2d50994c09

Can probably use some animations, but tuning that up will come up later

It will open a feedback survey for an option if there's one
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants