[Customer Center] Create `CustomerCenterView` #3919

vegaro · 2024-05-28T14:43:04Z

Base branch is integration/customer_support_workflow so we don't merge into main yet

Borrows a lot from #3865

Creates a new CustomerCenterView that can be used as a customer support workflow starting point.

All details can be found in https://linear.app/revenuecat/project/sdk-support-workflow-cf7f6a1d5340/overview

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

RevenueCatUI/CustomerCenter/URLUtilities.swift

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

RevenueCatUI/CustomerCenter/Views/CustomerCenterView.swift

RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

JayShortway

Nice ship! Had some minor comments. I will let someone with more iOS knowhow approve though 😄

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

RevenueCatUI/CustomerCenter/Data/CustomerCenterTestData.swift

RevenueCatUI/CustomerCenter/Views/CustomerCenterView.swift

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

jamesrb1

I've only run the views via previews - is there a better way?
I wasn't able to see the Figma file, but have requested access.

To get it to compile I had to change LocalizedString from let enUS: String to let en_US: String (I think the linter made this change, but we should ignore its rule in this case), and CustomerCenterData.FeedbackSurvey.Option to CustomerCenterData.FeedbackSurveyOption.

I think this is going to be a great and widely used new feature.

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

RevenueCatUI/CustomerCenter/Views/WrongPlatformView.swift

vegaro · 2024-05-29T07:06:28Z

I've only run the views via previews - is there a better way?

I've been doing that as well, since making a purchase with PaywallsTester has been complicated. I was planning on looking into that today, so I can test deserialization, etc

To get it to compile I had to change LocalizedString from let enUS: String to let en_US: String (I think the linter made this change, but we should ignore its rule in this case), and CustomerCenterData.FeedbackSurvey.Option to CustomerCenterData.FeedbackSurveyOption.

Oops yes, that's on me. I fixed the linting issues and broke the compilation. Sorry about that

cc @jamesrb1

fire-at-will

This is going to be so cool! 🤩

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

RevenueCatUI/CustomerCenter/Views/CustomerCenterView.swift

RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

RevenueCatUI/CustomerCenter/Views/NoSubscriptionsView.swift

RevenueCatUI/CustomerCenter/Views/WrongPlatformView.swift

aboedo

looking great!!

RevenueCatUI/CustomerCenter/Data/CustomerCenterData.swift

RevenueCatUI/CustomerCenter/ViewModels/CustomerCenterViewModel.swift

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

RevenueCatUI/CustomerCenter/Views/WrongPlatformView.swift

vegaro · 2024-06-07T15:12:43Z

It looks like I still have to fix some availability checks, but this is good for another pass I think :)

tonidero · 2024-06-10T07:17:21Z

RevenueCatUI/CustomerCenter/Data/CustomerCenterConfigData.swift

+        let dark: RCColor
+
+        enum Mode: String {
+            case system = "SYSTEM"


Should this also have light/dark modes?

going to remove this for now, took this from the draft API and it is meant to be used later as an indication that it should be using the accent color from the app. Since we haven't defined the API completely and I am not using it I will remove it

I am actually removing the whole appearance object, to keep things tidy

tonidero · 2024-06-10T07:23:44Z

RevenueCatUI/CustomerCenter/Views/ManageSubscriptionsView.swift

+    @ObservedObject
+    private(set) var viewModel: ManageSubscriptionsViewModel
+
+    let openURL: OpenURLAction


Hmm this seems unused? (Maybe you're planning to use it later though)

Oh yes, I had a contact support button, that I removed because it's not possible to configure it, and this is leftovers. Removing!

NachoSoto · 2024-06-10T23:50:19Z

RevenueCatUI/CustomerCenter/ViewModels/CustomerCenterViewModel.swift

+@available(macOS, unavailable)
+@available(tvOS, unavailable)
+@available(watchOS, unavailable)
+class CustomerCenterViewModel: ObservableObject {


Strongly suggest making these @MainActor 😇

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

tonidero · 2024-06-12T14:49:25Z

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

+                case .success:
+                    self.refundRequestStatus = "Refund granted successfully!"
+                case .userCancelled:
+                    self.refundRequestStatus = "Refund canceled"


We probably will need to localize these? I'm seeing that their usage is combined with another string so we would need to localize this (with String(localized: "") and the other text where it's used (in order to avoid localizing all the combinations of these

Separately, but I don't really like how these are localized with SwiftUI, since we don't have any compilation-time check that all the localizations are there... Maybe we should extract all these to strings enums so we have it better organized...

right, I agree with the localization... I am surprised xcode doesn't warn or anything. We should come back to this because if I am not wrong it's the same mechanism in Paywalls right?

RevenueCatUI/CustomerCenter/Data/CustomerCenterConfigTestData.swift

RevenueCatUI/CustomerCenter/ViewModels/ManageSubscriptionsViewModel.swift

vegaro · 2024-06-13T14:55:26Z

I ended up removing LocalizedString because localization will most likely be handled in a different way and this was making the response more complex c0a38a1 (#3919)

vegaro · 2024-06-17T12:23:14Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

[Customer Center] Create CustomerCenterView #3919 👈
[Customer Center] Initial implementation #3967 : 3 other dependent PRs (#3933 , #3959 , #3968 )
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vegaro and the rest of your teammates on Graphite

tonidero

We probably still need to handle localization and it would be great to have someone more familiar with SwiftUI take a look, but everything makes sense to me!

tonidero · 2024-06-28T09:34:24Z

RevenueCatUI/CustomerCenter/Data/CustomerCenterConfigData.swift

+        case missingPurchase = "MISSING_PURCHASE"
+        case refundRequest = "REFUND_REQUEST"
+        case changePlans = "CHANGE_PLANS"
+        case cancel = "CANCEL"


Oh I was using lowercase for these in the backend... I'm ok changing them to uppercase though 👍

tonidero · 2024-06-28T09:40:01Z

RevenueCatUI/CustomerCenter/URLUtilities.swift

+
+        // swiftlint:disable:next todo
+        // TODO: make configurable
+        let urlString = "mailto:support@revenuecat.com?subject=\(encodedSubject)&body=\(encodedBody)"


We will be sending these from the backend soon. But we can address this todo in a separate PR 👍

vegaro · 2024-06-28T09:46:51Z

Thank you @tonidero! Most of the hardcoded strings will go away since we are going to try to localize everything in the backend. So that's for future PRs.

vegaro · 2024-06-28T10:16:52Z

Going to merge it since the PRs are accumulating. @jamesrb1 feel free to make more comments that I can address in another PR if needed

Base branch is `integration/customer_support_workflow` so we don't merge into `main` yet Borrows a lot from #3865 Creates a new `CustomerCenterView` that can be used as a customer support workflow starting point. All details can be found in https://linear.app/revenuecat/project/sdk-support-workflow-cf7f6a1d5340/overview --------- Co-authored-by: Will Taylor <wtaylor151@gmail.com> Co-authored-by: James Borthwick <109382862+jamesrb1@users.noreply.github.com>

vegaro added pr:feat A new feature feat:Customer Center labels May 28, 2024

vegaro changed the title ~~[Support Workflow] Create CustomerCenterView~~ [Support Workflow] Create CustomerCenterView May 28, 2024

vegaro changed the base branch from main to integration/customer_support_workflow May 28, 2024 14:52

vegaro force-pushed the sdk-3433-supportview branch from be92ded to ab9c5cf Compare May 28, 2024 16:07

vegaro commented May 28, 2024

View reviewed changes

vegaro marked this pull request as ready for review May 28, 2024 16:08

vegaro requested review from joshdholtz, MarkVillacampa, fire-at-will and a team May 28, 2024 16:08

JayShortway reviewed May 28, 2024

View reviewed changes

jamesrb1 approved these changes May 29, 2024

View reviewed changes

fire-at-will reviewed May 29, 2024

View reviewed changes

aboedo reviewed Jun 3, 2024

View reviewed changes

vegaro mentioned this pull request Jun 7, 2024

WIP: support workflow #3865

Closed

vegaro requested review from aboedo, JayShortway and jamesrb1 June 7, 2024 15:11

tonidero reviewed Jun 10, 2024

View reviewed changes

NachoSoto reviewed Jun 10, 2024

View reviewed changes

vegaro force-pushed the sdk-3433-supportview branch from 07422a6 to 973d7ec Compare June 11, 2024 13:35

tonidero reviewed Jun 12, 2024

View reviewed changes

vegaro changed the base branch from integration/customer_support_workflow to request-a-refund June 17, 2024 12:23

This was referenced Jun 17, 2024

[Customer Center] Add API call to get Customer Center config #3933

Merged

Create CustomerCenterView #3966

Closed

vegaro added 14 commits June 27, 2024 12:14

CustomerCenterConfigTestData debug only

9851c1f

extracts strings

72154ce

add lines

9752176

more strings

5115202

remove LocalizedString

1098378

@jamesrb1 suggestions

b5955d6

lint

0bf3757

&& (swift(>=5.9) && !os(visionOS))

98bb9f2

fix linter

c07bb1d

fix macros

7955877

fix tests

21b52f6

fix tests

6a6b003

change localization of date

239f10a

fix pod lib lint

8f21718

vegaro force-pushed the integration/customer_support_workflow branch from 027b480 to 83d4b1a Compare June 27, 2024 10:15

vegaro force-pushed the sdk-3433-supportview branch from 2858c16 to 8f21718 Compare June 27, 2024 10:15

tonidero approved these changes Jun 28, 2024

View reviewed changes

vegaro merged commit 4ab05c3 into integration/customer_support_workflow Jun 28, 2024
24 checks passed

vegaro deleted the sdk-3433-supportview branch June 28, 2024 10:16

This was referenced Jul 5, 2024

[Customer Center] Add contact support button #4023

Merged

[Customer Center] Create a completion handler #4028

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Customer Center] Create `CustomerCenterView` #3919

[Customer Center] Create `CustomerCenterView` #3919

vegaro commented May 28, 2024 •

edited

Loading

JayShortway left a comment

jamesrb1 left a comment •

edited

Loading

vegaro commented May 29, 2024

fire-at-will left a comment

aboedo left a comment

vegaro commented Jun 7, 2024

tonidero Jun 10, 2024

vegaro Jun 10, 2024

vegaro Jun 10, 2024

tonidero Jun 10, 2024

vegaro Jun 10, 2024

NachoSoto Jun 10, 2024

tonidero Jun 12, 2024

tonidero Jun 12, 2024

vegaro Jun 12, 2024

vegaro commented Jun 13, 2024

vegaro commented Jun 17, 2024 •

edited

Loading

tonidero left a comment

tonidero Jun 28, 2024

tonidero Jun 28, 2024

vegaro commented Jun 28, 2024

vegaro commented Jun 28, 2024

[Customer Center] Create CustomerCenterView #3919

[Customer Center] Create CustomerCenterView #3919

Conversation

vegaro commented May 28, 2024 • edited Loading

JayShortway left a comment

Choose a reason for hiding this comment

jamesrb1 left a comment • edited Loading

Choose a reason for hiding this comment

vegaro commented May 29, 2024

fire-at-will left a comment

Choose a reason for hiding this comment

aboedo left a comment

Choose a reason for hiding this comment

vegaro commented Jun 7, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro commented Jun 13, 2024

vegaro commented Jun 17, 2024 • edited Loading

tonidero left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vegaro commented Jun 28, 2024

vegaro commented Jun 28, 2024

[Customer Center] Create `CustomerCenterView` #3919

[Customer Center] Create `CustomerCenterView` #3919

vegaro commented May 28, 2024 •

edited

Loading

jamesrb1 left a comment •

edited

Loading

vegaro commented Jun 17, 2024 •

edited

Loading