Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Customer Center] Add contact support button #4023

Merged

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Jul 5, 2024

Add contact support button to the ManageSubscriptionsView

@vegaro
Copy link
Contributor Author

vegaro commented Jul 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @vegaro and the rest of your teammates on Graphite Graphite

@vegaro vegaro changed the title Add contact support button [Customer Center] Add contact support button Jul 5, 2024
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from d0bbe8a to 8fef6d1 Compare July 5, 2024 18:09
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 8fef6d1 to b8bd53f Compare July 6, 2024 06:42
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from b8bd53f to 99ecb10 Compare July 6, 2024 06:45
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 99ecb10 to 9efea65 Compare July 6, 2024 07:43
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 9efea65 to 4569a03 Compare July 8, 2024 10:35
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 4569a03 to 647fd79 Compare July 8, 2024 10:38
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 647fd79 to 76e80a6 Compare July 8, 2024 14:07
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 76e80a6 to 68385b1 Compare July 8, 2024 16:12
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 68385b1 to 2af82b5 Compare July 8, 2024 18:42
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 2af82b5 to 19fa733 Compare July 8, 2024 19:52
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from 19fa733 to 37cd710 Compare July 8, 2024 20:13
@vegaro vegaro force-pushed the 06-21-add_colors_support branch 2 times, most recently from e60b2fe to 183f250 Compare July 19, 2024 16:28
Base automatically changed from 06-21-add_colors_support to integration/customer_support_workflow July 19, 2024 16:38
An error occurred while trying to automatically change base from 06-21-add_colors_support to integration/customer_support_workflow July 19, 2024 16:38
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from f36de93 to 96e2c14 Compare July 22, 2024 08:47
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch 3 times, most recently from 526570e to e38f240 Compare July 22, 2024 11:58
@vegaro vegaro marked this pull request as ready for review July 22, 2024 11:58
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch 4 times, most recently from 84d3f0e to c0dc9d5 Compare July 26, 2024 21:58
@vegaro vegaro marked this pull request as draft July 26, 2024 21:59
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from c0dc9d5 to 7dc9861 Compare July 29, 2024 10:28
@vegaro vegaro marked this pull request as ready for review July 29, 2024 13:36
@vegaro vegaro requested a review from a team July 29, 2024 13:37
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

RevenueCatUI/CustomerCenter/URLUtilities.swift Outdated Show resolved Hide resolved
action: {
if let supportInformation = self.supportInformation {
let subject = self.localization.commonLocalizedString(for: .defaultSubject)
let body = self.localization.commonLocalizedString(for: .defaultBody)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be good in future iterations to have this body include some info on the device/user, but we can do this in follow-up PRs 👍

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I will do that this week, I think it will be super useful

vegaro and others added 3 commits July 29, 2024 17:32
@vegaro vegaro force-pushed the 07-05-add_contact_support_button branch from d98dc5f to 802f957 Compare July 29, 2024 16:47
@vegaro vegaro merged commit 2977e6b into integration/customer_support_workflow Jul 29, 2024
5 checks passed
@vegaro vegaro deleted the 07-05-add_contact_support_button branch July 29, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants