Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-added the RevenueCatUI tests job on every commit #4113

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Re-added the RevenueCatUI tests job on every commit #4113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cab3a63
re-added the ui tests job
aboedo Jul 24, 2024
9ae62e3
improvements from PR comments
aboedo Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ jobs:
name: RevenueCatUI API Tests
command: bundle exec fastlane build_revenuecatui_api_tester

spm-revenuecat-ui-ios-17:
run-revenuecat-ui-ios-17:
<<: *base-job
parameters:
xcode_version:
Expand Down Expand Up @@ -1269,7 +1269,7 @@ workflows:
jobs:
- spm-revenuecat-ui-ios-15
- spm-revenuecat-ui-ios-16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should also rename these, if they are doing the same thing but on different iOS versions...

- spm-revenuecat-ui-ios-17
- run-revenuecat-ui-ios-17

build-test:
when:
Expand All @@ -1282,6 +1282,7 @@ workflows:
- lint
- run-test-ios-17
- pod-lib-lint
- run-revenuecat-ui-ios-17

create-tag:
when:
Expand Down Expand Up @@ -1406,7 +1407,7 @@ workflows:
- spm-release-build-xcode-15
- spm-revenuecat-ui-ios-15
- spm-revenuecat-ui-ios-16
- spm-revenuecat-ui-ios-17
- run-revenuecat-ui-ios-17
- spm-revenuecat-ui-watchos
- installation-tests-cocoapods
- installation-tests-swift-package-manager
Expand Down