Re-added the RevenueCatUI tests job on every commit #4113
Conversation
|
Oh, I guess re-doing the names sadly means that I'd have to also update the name in the required jobs list. |
.circleci/config.yml
Outdated
| - lint: | ||
| name: "swiftlint" | ||
| - run-test-ios-17: | ||
| name: "Unit tests" | ||
| - pod-lib-lint: | ||
| name: "Pod lib lint" | ||
| - spm-revenuecat-ui-ios-17: | ||
| name: "RevenueCatUI tests" |
There was a problem hiding this comment.
let me know if the name feels like it's not adding much and / or making it harder to map the jobs as they show up in github to the circleCI config. I just did this because the name spm-revenuecat-ui-ios-17 seemed so specific that it didn't seem like a vital check to have until I realized what it was
There was a problem hiding this comment.
Hmm how about renaming the job to something like run-revenuecat-ui-ios-17 instead? I feel changing the name like this might make it harder to try to find what job is failing later.
|
@RCGitBot please test |
| @@ -1269,7 +1269,7 @@ workflows: | |||
| jobs: | |||
| - spm-revenuecat-ui-ios-15 | |||
| - spm-revenuecat-ui-ios-16 | |||
There was a problem hiding this comment.
I do wonder if we should also rename these, if they are doing the same thing but on different iOS versions...
I realized that we weren't running the suite of tests from RevenueCatUI in every commit. I missed this one because the name made it seem like it was a test specific to SPM, but it's just that it could only be run through SPM at the time. It can now be run from Xcode, but that's a separate story, so for now this just re-adds it and clarifies the naming a bit
**This is an automatic release.** ### Bugfixes * Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot] (@dependabot[bot]) * Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update deployment targets for tests (#4145) via Andy Boedo (@aboedo) * Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy Boedo (@aboedo) * Clean up API Testers (#4141) via Andy Boedo (@aboedo) * More project structure cleanup (#4131) via Andy Boedo (@aboedo) * temporarily disables purchasetester deploy (#4133) via Andy Boedo (@aboedo) * Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo) * Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo) * tests trigger: add target-branch parameter to trigger from the right branch (#4121) via Andy Boedo (@aboedo) * Re-added the RevenueCatUI tests job on every commit (#4113) via Andy Boedo (@aboedo)
I realized that we weren't running the suite of tests from RevenueCatUI in every commit.
I missed this one because the name made it seem like it was a test specific to SPM, but it's just that it could only be run through SPM at the time.
It can now be run from Xcode, but that's a separate story, so for now this just re-adds it and clarifies the naming a bit