Fix Paywalls crash on iOS 18 beta #4154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aboedo
commented
Aug 7, 2024
Comment on lines
117
to
118
| let iOSVersionWithCrash = OperatingSystemVersion(majorVersion: 18, minorVersion: 0, patchVersion: 0) | ||
| let isIOSVersionWithCrash = ProcessInfo.processInfo.isOperatingSystemAtLeast(iOSVersionWithCrash) |
There was a problem hiding this comment.
note: I'm kinda going out of my way to not name this iOS18 so that people don't get knocked for having references to unreleased software, just in case. I've seen Apple's code checks get really dumb.
There was a problem hiding this comment.
might even be worth extracting the 18 to a different variable just in case too
There was a problem hiding this comment.
majorVersion: 1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1+1
|
can't approve because I opened the PR but 🚢 |
MarkVillacampa
approved these changes
Aug 7, 2024
MarkVillacampa
pushed a commit
that referenced
this pull request
Aug 7, 2024
**This is an automatic release.** ### Bugfixes * Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot] (@dependabot[bot]) * Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update deployment targets for tests (#4145) via Andy Boedo (@aboedo) * Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy Boedo (@aboedo) * Clean up API Testers (#4141) via Andy Boedo (@aboedo) * More project structure cleanup (#4131) via Andy Boedo (@aboedo) * temporarily disables purchasetester deploy (#4133) via Andy Boedo (@aboedo) * Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo) * Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo) * tests trigger: add target-branch parameter to trigger from the right branch (#4121) via Andy Boedo (@aboedo) * Re-added the RevenueCatUI tests job on every commit (#4113) via Andy Boedo (@aboedo)
NachoSoto
reviewed
Aug 7, 2024
| @@ -84,11 +84,20 @@ extension View { | |||
| #endif | |||
| } | |||
|
|
|||
| private static var isIOSVersionWithCrash: Bool { | |||
There was a problem hiding this comment.
This is going to get called a million times as the view is re-evaluated. I'd cache it 😇
MarkVillacampa
added a commit
that referenced
this pull request
Aug 12, 2024
The issue has been fixed in iOS 18.1 beta 2 / iOS 18 beta 6. Original PR: #4154
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
Temporary fix for #4150 Hopefully iOS 8 beta 6 fixes `ViewThatFits` and we can roll this back, but this should help in the meantime --------- Co-authored-by: Mark Villacampa <m@markvillacampa.com>
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
**This is an automatic release.** ### Bugfixes * Fix Paywalls crash on iOS 18 beta (#4154) via Andy Boedo (@aboedo) ### Dependency Updates * Bump danger from 9.4.3 to 9.5.0 (#4143) via dependabot[bot] (@dependabot[bot]) * Bump nokogiri from 1.16.6 to 1.16.7 (#4129) via dependabot[bot] (@dependabot[bot]) * Bump fastlane from 2.221.1 to 2.222.0 (#4130) via dependabot[bot] (@dependabot[bot]) ### Other Changes * Update deployment targets for tests (#4145) via Andy Boedo (@aboedo) * Deploy purchaserTester: clean up dry-run parameter (#4140) via Andy Boedo (@aboedo) * Clean up API Testers (#4141) via Andy Boedo (@aboedo) * More project structure cleanup (#4131) via Andy Boedo (@aboedo) * temporarily disables purchasetester deploy (#4133) via Andy Boedo (@aboedo) * Fix trigger all tests branch (#4135) via Andy Boedo (@aboedo) * Clean up XCWorkspace and testing apps (#4111) via Andy Boedo (@aboedo) * tests trigger: add target-branch parameter to trigger from the right branch (#4121) via Andy Boedo (@aboedo) * Re-added the RevenueCatUI tests job on every commit (#4113) via Andy Boedo (@aboedo)
nyeu
pushed a commit
that referenced
this pull request
Oct 2, 2024
The issue has been fixed in iOS 18.1 beta 2 / iOS 18 beta 6. Original PR: #4154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix for #4150
Hopefully iOS 8 beta 6 fixes
ViewThatFitsand we can roll this back, but this should help in the meantime