Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Godot 3.3 #2215

Merged
merged 10 commits into from
May 29, 2021
Merged

Upgrade to Godot 3.3 #2215

merged 10 commits into from
May 29, 2021

Conversation

athariqk
Copy link
Member

@athariqk athariqk commented May 6, 2021

Reset buttons focus mode in various places due to it being marked deprecated with 3.3

Engine related issues this definitely fixes:
Closes #1126 (no problems found on testing)
Closes #1095

Others may need some reviewings to see if they are properly fixed with the new version.

Closes #2204
closes #2058

@athariqk athariqk added the review label May 6, 2021
@athariqk athariqk added this to the Release 0.5.3.2 milestone May 6, 2021
@athariqk athariqk requested review from hhyyrylainen and FuJa0815 May 6, 2021 06:59
@hhyyrylainen
Copy link
Member

I'll do the CI image upgrading part (I was kinda waiting until I got the new DevCenter CI working before working on the godot upgrade myself) and CircleCI config once this is otherwise ready.

@athariqk
Copy link
Member Author

athariqk commented May 6, 2021

No problem, I'll mark this as a draft for now.

@hhyyrylainen
Copy link
Member

@Kasterisk could you fix the conflicts with master and update this (MicrobeEditor.tscn)? I'll have the CI images to ready to go by then.

@athariqk
Copy link
Member Author

Sure, will do that in a moment.

@hhyyrylainen
Copy link
Member

Looks like there's even a maintenance release now: https://godotengine.org/article/maintenance-release-godot-3-3-2
After the conflicts are resolved, I'll update to that maintenance version (though, I'll leave CircleCI running on 3.3 as it shouldn't really affect things to just use it for the jetbrains check).

@athariqk
Copy link
Member Author

Solved merge conflict.

@hhyyrylainen
Copy link
Member

I saw something going on with the jetbrains tools here, so as I need to make a new image anyway, I'll update them as well... so it's going to take until tomorrow.

@hhyyrylainen hhyyrylainen marked this pull request as ready for review May 28, 2021 21:18
@hhyyrylainen
Copy link
Member

I did the changes this needs. Didn't test yet if this closes all the mentioned issues. The CI failure seems to be that for some reason the CDN doesn't want to let anyone download the new CI image I just uploaded, but it seems to get farther and farther when I manually download, so maybe a little bit of time will sort that out.

@hhyyrylainen hhyyrylainen merged commit 1bbfc95 into master May 29, 2021
@hhyyrylainen hhyyrylainen deleted the godot_3.3 branch May 29, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
2 participants