perf: skip line break mappings #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would you consider this safe to ship in a patch? I don't know if any consumer would rely on that information. |
|
I guess no one would rely on this information but I'm not sure. |
|
Ok, let's try it. If there are any cases I'd revert it and move to a minor then. Thanks! |
1 task
6 tasks
github-merge-queue bot
pushed a commit
to rolldown/rolldown
that referenced
this pull request
Dec 1, 2024
<!-- Thank you for contributing! --> ### Description Another one I thought I would port from magic-string: - Rich-Harris/magic-string#284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes line break mappings from the output sourcemap and reduces the output sourcemap.
visualizer before
visualizer after
esbuild does not output them and probably fine to skip them.
example repl
visualizer for that